Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr: don't resize binary opaque when the type flen is unspecified (#16617) #16712

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #16617

What is changed and how it works?

Issue Number: Close #16616

What's Changed:

If the flen is unspecified (-1), don't resize the string to try to produce extra zero. ref pingcap/tidb#51586

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Copy link
Contributor

ti-chi-bot bot commented Mar 28, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breezewish
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@YangKeao
Copy link
Member

/cc @breezewish @gengliqi

@YangKeao
Copy link
Member

/run-all-tests

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 15, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Apr 18, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Apr 18, 2024
@breezewish
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 18, 2024

@breezewish: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 18, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 0719369

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Apr 18, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 18, 2024

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YangKeao
Copy link
Member

YangKeao commented Apr 18, 2024

/run-all-tests

1 similar comment
@YangKeao
Copy link
Member

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit 77c2c7f into tikv:release-7.1 Apr 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none size/S status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals type/cherry-pick-for-release-7.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants