Fix output on short version flag #5348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep -V behavior same with v2.x Signed-off-by: lucklove <gnu.crazier@gmail.com>
lucklove
force-pushed
the
bugfix/revert-short-version-behavior
branch
from
b424913
to
0dd3b16
Compare
sticnarf
approved these changes
Aug 28, 2019
sticnarf
added
the
status/can-merge
|
/run-all-tests |
YangKeao
added a commit
to YangKeao/tikv
that referenced
this pull request
Sep 5, 2019
This reverts commit 3c49ba8.
lucklove
added
needs-cherry-pick-release-3.0
|
/run-cherry-picker |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-3.1 failed |
lucklove
added a commit
that referenced
this pull request
Sep 23, 2019
Signed-off-by: lucklove <gnu.crazier@gmail.com>
lucklove
added a commit
that referenced
this pull request
Sep 23, 2019
Signed-off-by: lucklove <gnu.crazier@gmail.com> Conflicts: src/bin/tikv-server.rs
sre-bot
pushed a commit
that referenced
this pull request
Sep 23, 2019
lucklove
added a commit
that referenced
this pull request
Sep 24, 2019
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep -V behavior same with v2.x
Signed-off-by: lucklove gnu.crazier@gmail.com
What have you changed?
The -V output format of tikv-server and tikv-ctl.
The output of -V in v2.x is something like:
However, in v3.x, it's something like:
And in the newest master, it's:
We should keep the output format same with v2.x, because the tidb and pd's output format is that. I think they should have a unified behavior.
What is the type of the changes?
How is the PR tested?
manual test
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No
Does this PR affect
tidb-ansible?No
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Any examples? (optional)