expression: fix the issue that incorrect result for a predicate that uses the CHAR() function #16014

Reminiscent · 2020-04-02T09:08:50Z

What problem does this PR solve?

Issue Number: close #15986

What is changed and how it works?

When we use the string type to determine the bool value, the string type is converted to a float type instead of an int type.

Check List

Tests

Unit test
Integration test

…uses the CHAR() function

Reminiscent · 2020-04-02T12:30:40Z

expression/expression.go

-					iVal, err = HandleOverflowOnSelection(sc, iVal, err)
-					if err != nil {
-						return err
-					}


The function types.StrToFloat does not generate an overflow error, so the function HandleOverflowOnSelection and the test TestVecToBool are both unneeded.

codecov · 2020-04-02T12:31:58Z

Codecov Report

❗ No coverage uploaded for pull request base (master@2b03cf2). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #16014   +/-   ##
===========================================
  Coverage          ?   80.3714%           
===========================================
  Files             ?        506           
  Lines             ?     136317           
  Branches          ?          0           
===========================================
  Hits              ?     109560           
  Misses            ?      18215           
  Partials          ?       8542

SunRunAway

~~LGTM~~

SunRunAway

From #15986,

Interestingly, the first query results in the following warning:

mysql> show warnings;
+---------+------+------------------------------------------+
| Level   | Code | Message                                  |
+---------+------+------------------------------------------+
| Warning | 1292 | Truncated incorrect INTEGER value: '.9<' |
+---------+------+------------------------------------------+
1 row in set (0.00 sec)

Please add some test cases to ensure there's no this type of warnings anymore.

Reminiscent · 2020-04-03T02:33:13Z

From #15986,

Interestingly, the first query results in the following warning:

mysql> show warnings;
+---------+------+------------------------------------------+
| Level   | Code | Message                                  |
+---------+------+------------------------------------------+
| Warning | 1292 | Truncated incorrect INTEGER value: '.9<' |
+---------+------+------------------------------------------+
1 row in set (0.00 sec)

Please add some test cases to ensure there's no this type of warnings anymore.

The warning seems can not be eliminated. Because in the implementation of TIDB, when the string type cannot be completely converted to the float type, it will prompt this warning. @SunRunAway PTAL

SunRunAway

LGTM

Reminiscent · 2020-04-13T02:26:14Z

@qw4990 @XuHuaiyu PTAL

qw4990

LGTM

sre-bot · 2020-04-14T02:54:10Z

/run-all-tests

sre-bot · 2020-04-14T02:56:39Z

@Reminiscent merge failed.

zz-jason · 2020-04-17T14:33:38Z

/merge

sre-bot · 2020-04-17T14:33:55Z

/run-all-tests

sre-bot · 2020-04-17T14:36:26Z

@Reminiscent merge failed.

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot · 2020-04-17T14:44:31Z

cherry pick to release-2.1 in PR #16556

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot · 2020-04-17T14:45:43Z

cherry pick to release-3.0 in PR #16557

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot · 2020-04-17T14:46:45Z

cherry pick to release-3.1 in PR #16558

…cap#16014)

sre-bot · 2020-04-17T14:47:45Z

cherry pick to release-4.0 in PR #16559

…uses the CHAR() function (#16014) (#16558)

…uses the CHAR() function (#16014) (#16559)

…uses the CHAR() function (#16014) (#16557)

Reminiscent added 2 commits April 2, 2020 17:01

expression: fix the issue that incorrect result for a predicate that …

c0be098

…uses the CHAR() function

Merge branch 'master' of https://github.com/pingcap/tidb into issue15986

1f2e138

Reminiscent added type/bug-fix This PR fixes a bug. component/expression needs-cherry-pick-4.0 labels Apr 2, 2020

Reminiscent requested review from SunRunAway, qw4990 and XuHuaiyu April 2, 2020 09:08

Reminiscent requested a review from a team as a code owner April 2, 2020 09:08

ghost removed their request for review April 2, 2020 09:08

Reminiscent added 3 commits April 2, 2020 17:39

fix tests

788c2af

delete unused test and add some comments

a167f9b

Merge branch 'master' of https://github.com/pingcap/tidb into issue15986

45973fc

Reminiscent commented Apr 2, 2020

View reviewed changes

add more tests

3427ffa

SunRunAway reviewed Apr 2, 2020

View reviewed changes

Reminiscent requested a review from SunRunAway April 3, 2020 02:33

Reminiscent self-assigned this Apr 7, 2020

SunRunAway reviewed Apr 9, 2020

View reviewed changes

qw4990 approved these changes Apr 14, 2020

View reviewed changes

qw4990 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Apr 14, 2020

Merge branch 'master' into issue15986

5588664

Reminiscent added the needs-cherry-pick-2.1 label Apr 14, 2020

Reminiscent added needs-cherry-pick-2.1 labels Apr 16, 2020

Merge branch 'master' into issue15986

b2ac92c

zz-jason merged commit bdbdbae into pingcap:master Apr 17, 2020

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 17, 2020

cherry pick pingcap#16014 to release-2.1

c685c6c

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot mentioned this pull request Apr 17, 2020

expression: fix the issue that incorrect result for a predicate that uses the CHAR() function (#16014) #16556

Closed

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 17, 2020

cherry pick pingcap#16014 to release-3.0

c93e523

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot mentioned this pull request Apr 17, 2020

expression: fix the issue that incorrect result for a predicate that uses the CHAR() function (#16014) #16557

Merged

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 17, 2020

cherry pick pingcap#16014 to release-3.1

a0fa32e

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot mentioned this pull request Apr 17, 2020

expression: fix the issue that incorrect result for a predicate that uses the CHAR() function (#16014) #16558

Merged

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 17, 2020

expression: fix the issue that incorrect result for a predicat… (ping…

c9915ff

…cap#16014)

sre-bot mentioned this pull request Apr 17, 2020

expression: fix the issue that incorrect result for a predicate that uses the CHAR() function (#16014) #16559

Merged

Reminiscent removed the needs-cherry-pick-2.1 label Apr 26, 2020

sre-bot added a commit that referenced this pull request Apr 28, 2020

expression: fix the issue that incorrect result for a predicate that …

a81e7d0

…uses the CHAR() function (#16014) (#16558)

sre-bot added a commit that referenced this pull request Apr 30, 2020

expression: fix the issue that incorrect result for a predicate that …

74b63e2

…uses the CHAR() function (#16014) (#16559)

SunRunAway pushed a commit that referenced this pull request Apr 30, 2020

expression: fix the issue that incorrect result for a predicate that …

04baec7

…uses the CHAR() function (#16014) (#16557)

Reminiscent deleted the issue15986 branch August 5, 2021 02:02

lcwangchao mentioned this pull request Jan 10, 2024

expression: remove useless HandleOverflowOnSelection #50279

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

expression: fix the issue that incorrect result for a predicate that uses the CHAR() function #16014

expression: fix the issue that incorrect result for a predicate that uses the CHAR() function #16014

Reminiscent commented Apr 2, 2020 •

edited

Loading

Reminiscent Apr 2, 2020 •

edited

Loading

codecov bot commented Apr 2, 2020 •

edited

Loading

SunRunAway left a comment •

edited

Loading

SunRunAway left a comment

Reminiscent commented Apr 3, 2020

SunRunAway left a comment

Reminiscent commented Apr 13, 2020

qw4990 left a comment

sre-bot commented Apr 14, 2020

sre-bot commented Apr 14, 2020

zz-jason commented Apr 17, 2020

sre-bot commented Apr 17, 2020

sre-bot commented Apr 17, 2020

sre-bot commented Apr 17, 2020

sre-bot commented Apr 17, 2020

sre-bot commented Apr 17, 2020

sre-bot commented Apr 17, 2020

expression: fix the issue that incorrect result for a predicate that uses the CHAR() function #16014

expression: fix the issue that incorrect result for a predicate that uses the CHAR() function #16014

Conversation

Reminiscent commented Apr 2, 2020 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Reminiscent Apr 2, 2020 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Apr 2, 2020 • edited Loading

Codecov Report

SunRunAway left a comment • edited Loading

Choose a reason for hiding this comment

SunRunAway left a comment

Choose a reason for hiding this comment

Reminiscent commented Apr 3, 2020

SunRunAway left a comment

Choose a reason for hiding this comment

Reminiscent commented Apr 13, 2020

qw4990 left a comment

Choose a reason for hiding this comment

sre-bot commented Apr 14, 2020

sre-bot commented Apr 14, 2020

zz-jason commented Apr 17, 2020

sre-bot commented Apr 17, 2020

sre-bot commented Apr 17, 2020

sre-bot commented Apr 17, 2020

sre-bot commented Apr 17, 2020

sre-bot commented Apr 17, 2020

sre-bot commented Apr 17, 2020

Reminiscent commented Apr 2, 2020 •

edited

Loading

Reminiscent Apr 2, 2020 •

edited

Loading

codecov bot commented Apr 2, 2020 •

edited

Loading

SunRunAway left a comment •

edited

Loading