-
Notifications
You must be signed in to change notification settings - Fork 60
Helix always crash ("[BUG] Segmentation fault") with dynamic libraries build by Windows rustc installed with x86_64-pc-windows-gnu (gcc compiler) #124
Comments
I think this is a known issue. What's your reason for using the gnu compiler over msvc? |
Gnu is free & open source. I doubt if msvc compile is free without VS license for commercial use (any MS official clarification would be good) |
Yea we should definitely investigate this. Is it possible to add this scenario to our app veyor matrix? |
I have the same issue. Here's the output of running bundle exec rake from exampes/text_transform |
I can reproduce this. |
It looks like the MSVC version is actually preferred for Rust on Windows, including by Mozilla. It looks like you only need the Visual C++ Build Tools and not Visual Studio itself. AFAICT, any proprietary Windows components aren't bundled and are instead dynamically linked at runtime. I'm certainly not an expert here, but I don't think there are any licensing concerns around using the MSVC compiler. That said, it's not a bad idea to try to get things working with the GNU compiler. However, unless there are strong concrete concerns with MSVC, I don't think this will be a priority. |
Also, the rubyinstaller project, which is probably the most used ruby installation for windows, uses the GNU compiler toolchain. |
When install Rust using rustup-init.exe, with x86_64-pc-windows-msvc, helix can run. However, with x86_64-pc-windows-gnu (choose custom install) it always crash (Tested with msvc compiler not installed in the OS).
To reproduce, try the flipper application from https://usehelix.com/getting_started. ( Or attached here: flipper.zip )
Running "rake irb" under folder "D:/dev/flipper/crates/text_transform" got this crash:
More info
The text was updated successfully, but these errors were encountered: