Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix browser sourcemaps (in dev/tdd mode) #9

Merged
merged 1 commit into from
May 1, 2018
Merged

Fix browser sourcemaps (in dev/tdd mode) #9

merged 1 commit into from
May 1, 2018

Commits on May 1, 2018

  1. Fix browser sourcemaps (in dev/tdd mode) 

    Previously, webpack was just bundling (concatenating, basically) all the
source files into one big file. This includes the `sourceMappingURL` at
the bottom of each file (emitted by typescript). Since the browser only
expect at most one such comment at the bottom of a file, it effectively
means that only the last file's source map get recognized by the
browser.

This fixes it using the Sourcemap Loader which extracts the input source
maps and re-emit them once after bundling.

The VSCode debug workflow was unaffected by this problem, since it uses
the commonjs build directly without using webpack to bundle them.

Fixes #5.
    @chancancode
    chancancode committed May 1, 2018
    Configuration menu
    Copy the full SHA
    0420ef7 View commit details
    Browse the repository at this point in the history