Rubocop: More fixes and cleanups

.rubocop.yml

@@ -61,4 +61,7 @@ Lint/UnusedBlockArgument:
 Lint/UnusedMethodArgument:
   Enabled: false
 
+Style/HashSyntax:
+  EnforcedStyle: hash_rockets
+
 inherit_from: .rubocop_todo.yml

.rubocop_todo.yml

@@ -1,28 +1,8 @@
-# Offense count: 14
-Lint/ParenthesesAsGroupedExpression:
-  Enabled: false
-
-# Offense count: 5
-# Cop supports --auto-correct.
-Lint/UnusedBlockArgument:
-  Enabled: false
-
-# Offense count: 3
-# Cop supports --auto-correct.
-Lint/UnusedMethodArgument:
-  Enabled: false
-
 # Offense count: 3
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/FormatString:
   Enabled: false
 
-# Offense count: 397
-# Cop supports --auto-correct.
-# Configuration parameters: SupportedStyles.
-Style/HashSyntax:
-  EnforcedStyle: hash_rockets
-
 # Offense count: 3
 Style/ModuleFunction:
   Enabled: false

bash/spec/bashrc_spec.rb

@@ -2,7 +2,7 @@
 
 describe 'bash::bashrc' do
 
-  let (:chef_run) do
+  let(:chef_run) do
     ChefSpec::Runner.new do |node|
       # fake opsworks
       node.default['opsworks'] = {}

haproxy/spec/backend_healthcheck_spec.rb

@@ -1,7 +1,7 @@
 require 'chefspec'
 
 describe 'haproxy::configure' do
-  let (:runner) do
+  let(:runner) do
     ChefSpec::Runner.new do |node|
       node.set[:opsworks][:layers][:nginxphpapp][:instances] = {}
       node.set[:opsworks][:layers][:app1][:instances] = {}
@@ -30,8 +30,8 @@
       }
     end
   end
-  let (:chef_run) { runner.converge('haproxy::configure') }
-  let (:node) { runner.node }
+  let(:chef_run) { runner.converge('haproxy::configure') }
+  let(:node) { runner.node }
 
   describe 'standard settings' do
     before do

hhvm-fcgi/spec/default_spec.rb

@@ -9,9 +9,9 @@
     @shellout.stub(:error!)
   end
 
-  let (:runner) { ChefSpec::Runner.new }
-  let (:chef_run) { runner.converge('hhvm-fcgi::default') }
-  let (:node) { runner.node }
+  let(:runner) { ChefSpec::Runner.new }
+  let(:chef_run) { runner.converge('hhvm-fcgi::default') }
+  let(:node) { runner.node }
 
   describe 'standard settings' do
     it 'installs hhvm and creates the config files' do

nodejs/recipes/npm.rb

@@ -13,9 +13,7 @@
 
 execute 'Install the latest npm' do
   command "#{Chef::Config[:file_cache_path]}/install-npm.sh"
-  environment ({
-    'clean' => 'no'
-  })
+  environment('clean' => 'no            ')
   not_if do
     File.exist?(npm_bin)
   end

percona/spec/server_spec.rb

@@ -1,7 +1,7 @@
 require 'chefspec'
 
 describe 'percona::server' do
-  let (:chef_run) do
+  let(:chef_run) do
     ChefSpec::Runner.new.converge('percona::server')
   end
 

php-apc/spec/configure_spec.rb

@@ -2,7 +2,7 @@
 
 describe 'php-apc::configure' do
 
-  let (:chef_run) do
+  let(:chef_run) do
     ChefSpec::Runner.new do |node|
       # fake opsworks
       node.default['opsworks'] = {}

php-fpm/spec/default_spec.rb

@@ -11,7 +11,7 @@
     @shellout.stub(:error!)
   end
 
-  let (:chef_run) do
+  let(:chef_run) do
     ChefSpec::Runner.new.converge('php-fpm::default')
   end
 

php-mysqli/spec/configure_spec.rb

@@ -1,7 +1,7 @@
 require 'chefspec'
 
 describe 'php-mysqli::configure' do
-  let (:chef_run) { ChefSpec::Runner.new.converge('php-mysqli::configure') }
+  let(:chef_run) { ChefSpec::Runner.new.converge('php-mysqli::configure') }
 
   it 'creates mysqli-settings.ini which contains the correct settings' do
 

php-xdebug/spec/default_spec.rb

@@ -2,7 +2,7 @@
 
 describe 'php-xdebug::default' do
 
-  let (:chef_run) do
+  let(:chef_run) do
     ChefSpec::Runner.new do |node|
       node.default['apt'] = {}
       node.default.apt['easybib'] = {}

statsd/spec/configure_spec.rb

@@ -2,7 +2,7 @@
 
 describe 'statsd::configure' do
 
-  let (:chef_run) do
+  let(:chef_run) do
     ChefSpec::Runner.new do |node|
       # fake opsworks
       node.default['opsworks'] = {}