Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): retrieve both state and props for displayMenu to trigger rerender #660

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

sun-tea
Copy link
Contributor

@sun-tea sun-tea commented Jul 29, 2019

  • Feature
  • Fix
  • Enhancement

Brief

displayMenu did not seem to trigger rerender despite being updated in the internal state, turns out I think it's because the way the variable was being retrieved would not trigger a rerender.

Todo - Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.

@spartDev spartDev assigned sun-tea and unassigned Artikodin and spartDev Jul 29, 2019
@spartDev spartDev added bug Something isn't working and removed need review labels Jul 29, 2019
@spartDev spartDev merged commit 5606ad3 into master Jul 29, 2019
@spartDev spartDev deleted the fix/Dropdown branch July 29, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants