-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Table): Add scrollable behaviour to the Table component #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artikodin
force-pushed
the
BP-369
branch
2 times, most recently
from
September 9, 2019 09:35
9a1d497
to
8bdb33d
Compare
Artikodin
force-pushed
the
BP-369
branch
3 times, most recently
from
September 11, 2019 15:52
055330b
to
c2cd12d
Compare
Artikodin
commented
Sep 11, 2019
@@ -89,31 +91,32 @@ class Table extends PureComponent { | |||
* @return {jsx} | |||
*/ | |||
renderHeader() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok guys I need to know what do think about that. Should I let component as method here or put it in an external file TableHeader
. Same question for the body and footer component.
spartDev
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to display severals rows and columns in a table. To avoid an unreadable shrink result we want to made our table scrollable in both axes (x & y).
The specifications says the total row should be visible if the user scroll to the bottom of the table. After reflexion with Mayssa we found that can be painful if there are a lots of rows. So we decided to stick it to the bottom.
What's new:
dataTotal
props passed to componentisScrollable
props is passed to it, the table will be scrollable when the number of columns or rows overflow the containercolsDef
props)After @spartDev review that PR he ask me to add some shadow when the table content overflow.
I started to develop that feature but I've no time to finish it.
What's missing:
top
,left
,right
,bottom
state in an objecthandleScroll
method to avoid that huge amount of condition(Table/elements.js)
I you find a better way to handle the shadow you're welcome to integrate it.
Related / Associated Jira Cards :
Todo - Checklist: