git_resource: additional portability fixes #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the repo has already been cloned, the extension checks for local modifications using output from `git status` and seeing if there are any lines using `wc -l`. This isn't portable to Windows, and trying to use hacks with `find /c /v ""` produce weird errors, so just do the line counting in Starlark. Additionally, use `os.path.join` consistently instead of manually concatenating strings with `/` to make Windows tools happy.
2 tasks
nicks
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the repo has already been cloned, the extension checks for
local modifications using output from
git statusand seeing ifthere are any lines using
wc -l. This isn't portable to Windows,and trying to use hacks with
find /c /v ""produce weird errors,so just do the line counting in Starlark.
Additionally, use
os.path.joinconsistently instead of manuallyconcatenating strings with
/to make Windows tools happy.Fixes #211.