Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should set _operationTimeout timeout *before* invoking _fn() #12

Closed
cybersam opened this issue Mar 10, 2014 · 0 comments
Closed

Should set _operationTimeout timeout *before* invoking _fn() #12

cybersam opened this issue Mar 10, 2014 · 0 comments

Comments

@cybersam
Copy link

attempt() and retry() both set the _operationTimeout timeout after invoking _fn(). Therefore, the time it takes _fn() to perform any synchronous processing (which could be significant) is ignored.

The timeout should be set immediately before invoking _fn().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cybersam