Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing client_test - a little help? #12

Closed
nathany opened this issue Dec 10, 2014 · 3 comments
Closed

Failing client_test - a little help? #12

nathany opened this issue Dec 10, 2014 · 3 comments

Comments

@nathany
Copy link
Contributor

nathany commented Dec 10, 2014

@bdotdub So far I haven't been able to figure out why the two tests on Travis CI are failing. They are both tests that have a bad push.

client_test.go:

  • bad push
  • good, bad, good, requeue of last good

https://travis-ci.org/timehop/apns

I added some logging into RunLoop where the 1 second sleep is. As it turns out, neither of these tests hit that (several other tests did log errors here, probably intentionally - invalid cert, etc).

@nathany nathany changed the title Failing tests - a little help? Failing client_test - a little help? Dec 10, 2014
@bdotdub
Copy link
Contributor

bdotdub commented Mar 2, 2015

Been trying to figure this one out as well. It's very inconsistent as you've seen.

Ultimately, the way I've written the tests the first time feel super brittle (actually spinning up tls servers for the Client tests.

Would it be too much of a cop out to say this will be fixed via #31 (#33)?

@nathany
Copy link
Contributor Author

nathany commented Mar 4, 2015

I'm happy with that. 😄

@bdotdub
Copy link
Contributor

bdotdub commented Mar 4, 2015

Sweet :)

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants