You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It has bothered me for quite a while that sunburst() takes two arguments to pass data. I would much prefer the approach in d3treeR that takes one data argument and attempts to resolve based on class. I have not changed for fear of breaking the API, but since we are taking major step in version, I think I will make the adjustment. Any feedback??
The text was updated successfully, but these errors were encountered:
FWIW, I agree with this change. Another benefit of having a single data argument is that it makes the sunburst() function pipe (%>%) friendly which it currently isn't if you're feeding it JSON data.
Thanks @jonmcalder and good point on the pipe-ability. I guess I could leave the jsondata and csvdata arguments around in this version with a deprecation warning, so that it is not as jarring a change.
It has bothered me for quite a while that
sunburst()
takes two arguments to passdata
. I would much prefer the approach ind3treeR
that takes onedata
argument and attempts to resolve based onclass
. I have not changed for fear of breaking the API, but since we are taking major step in version, I think I will make the adjustment. Any feedback??The text was updated successfully, but these errors were encountered: