Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAK API - change data argument #43

Closed
timelyportfolio opened this issue Jun 11, 2017 · 3 comments
Closed

BREAK API - change data argument #43

timelyportfolio opened this issue Jun 11, 2017 · 3 comments

Comments

@timelyportfolio
Copy link
Owner

timelyportfolio commented Jun 11, 2017

It has bothered me for quite a while that sunburst() takes two arguments to pass data. I would much prefer the approach in d3treeR that takes one data argument and attempts to resolve based on class. I have not changed for fear of breaking the API, but since we are taking major step in version, I think I will make the adjustment. Any feedback??

@jonmcalder
Copy link
Contributor

FWIW, I agree with this change. Another benefit of having a single data argument is that it makes the sunburst() function pipe (%>%) friendly which it currently isn't if you're feeding it JSON data.

@timelyportfolio
Copy link
Owner Author

Thanks @jonmcalder and good point on the pipe-ability. I guess I could leave the jsondata and csvdata arguments around in this version with a deprecation warning, so that it is not as jarring a change.

@timelyportfolio
Copy link
Owner Author

Going to close, since this seems done. Please reopen if there are any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants