Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat&chore: code-generation changes & improvements #5

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

y9vad9
Copy link
Member

@y9vad9 y9vad9 commented Jan 13, 2024

What's new

  • Constructors are now private
  • create function replaced with fake constructor function
  • oneofs are now have non-nullable member with Default in companion.

Is it breaking change?

Yes, as there no more 'create' function. Also, oneofs are now always not-null. If constructors were previously used, it requires migration to variant with lambda builder.

We cannot enforce consumers to use named parameters, and that's why I made private constructors. create as a function is not necessary.

…now private, create function replaced with fake constructor function, oneofs are now have non-nullable member with Default in companion)
@y9vad9 y9vad9 added the enhancement New feature or request label Jan 13, 2024
@y9vad9 y9vad9 self-assigned this Jan 13, 2024
@y9vad9 y9vad9 merged commit afa4e31 into master Jan 13, 2024
1 check failed
@y9vad9 y9vad9 deleted the code-generation-changes branch January 13, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant