Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Commit

Permalink
Add -dev inside directory name
Browse files Browse the repository at this point in the history
  • Loading branch information
cevian committed Aug 7, 2020
1 parent f1bb971 commit 24b1569
Show file tree
Hide file tree
Showing 9 changed files with 40 additions and 41 deletions.
11 changes: 4 additions & 7 deletions pkg/pgmodel/migrate.go
Original file line number Diff line number Diff line change
Expand Up @@ -361,8 +361,9 @@ func replaceSchemaNames(r io.ReadCloser) (string, error) {
}

//A migration file is inside a directory that is a semver version number. The filename itself has the format
//<migration file number)-<description>.sql. That file correspond to the semver of <dirname>-dev.<migration file number>
//All app versions >= to that semver will include the migration file
//<migration file number)-<description>.sql. That file correspond to the semver of <dirname>.<migration file number>
//where the migration file number is always part of prerelease tag.
//All app versions >= (inclusive) migration files's semver will include the migration file
func (t *Migrator) getMigrationFileVersion(dirName string, fileName string) (*semver.Version, error) {
var migrationFileNumber int
matches := migrationFileNameRegexp.FindStringSubmatch(fileName)
Expand All @@ -378,16 +379,12 @@ func (t *Migrator) getMigrationFileVersion(dirName string, fileName string) (*se
if err != nil {
return nil, fmt.Errorf("unable to parse version from directory %v: %w", dirName, err)
}
devPrVersion, err := semver.NewPRVersion("dev")
if err != nil {
return nil, fmt.Errorf("unable to create dev PR version: %w", err)
}
migrationNumberPrVersion, err := semver.NewPRVersion(fmt.Sprintf("%d", migrationFileNumber))
if err != nil {
return nil, fmt.Errorf("unable to create dev PR version: %w", err)
}

migrationFileVersion.Pre = append(migrationFileVersion.Pre, devPrVersion, migrationNumberPrVersion)
migrationFileVersion.Pre = append(migrationFileVersion.Pre, migrationNumberPrVersion)
return &migrationFileVersion, nil
}

Expand Down
68 changes: 34 additions & 34 deletions pkg/pgmodel/test_migrations/migration_files_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
INSERT INTO log VALUES('migration 0.10.1=1');
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
INSERT INTO log VALUES('migration 0.10.1=2');

0 comments on commit 24b1569

Please sign in to comment.