Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code #4364

Merged
merged 1 commit into from
May 20, 2022
Merged

Remove dead code #4364

merged 1 commit into from
May 20, 2022

Conversation

svenklemm
Copy link
Member

Remove noop ternary operator in cagg_rebuild_view_definition. We
return if finalized is true on line 2475 so the NIL would never
be reached in the ternary operator. Found by coverity.

Remove noop ternary operator in cagg_rebuild_view_definition. We
return if finalized is true on line 2475 so the NIL would never
be reached in the ternary operator. Found by coverity.
@svenklemm svenklemm marked this pull request as ready for review May 20, 2022 10:45
@svenklemm svenklemm requested a review from a team as a code owner May 20, 2022 10:45
@svenklemm svenklemm requested review from pmwkaa, mkindahl, fabriziomello, akuzm, gayyappan, jnidzwetzki, konskov, mfundul, nikkhils and a team and removed request for a team May 20, 2022 10:45
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #4364 (913833e) into main (8c5c7bb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4364      +/-   ##
==========================================
- Coverage   90.81%   90.80%   -0.02%     
==========================================
  Files         217      217              
  Lines       40249    40249              
==========================================
- Hits        36553    36548       -5     
- Misses       3696     3701       +5     
Impacted Files Coverage Δ
tsl/src/continuous_aggs/create.c 88.63% <0.00%> (ø)
src/loader/bgw_message_queue.c 85.52% <0.00%> (-2.64%) ⬇️
tsl/src/nodes/data_node_dispatch.c 97.10% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c5c7bb...913833e. Read the comment docs.

@svenklemm svenklemm merged commit b7472c8 into timescale:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants