Silence WARNING after extension update #5540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 8afdddc added the first step for deprecating the old format of Continuous Aggregate but just for PostgreSQL 15 and later versions. During the extension update we emit a message about the deprecation but this has being emited even if the user is using PostgreSQL versions before 15. Fixed it by emiting the WARNING just when PostgreSQL version is greater or equal to 15.
fabriziomello
added
continuous_aggregate
tech-debt
|
@mahipv, @svenklemm: please review this pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #5540 +/- ##
==========================================
- Coverage 90.46% 90.42% -0.05%
==========================================
Files 229 229
Lines 53856 53851 -5
==========================================
- Hits 48723 48696 -27
- Misses 5133 5155 +22 see 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jnidzwetzki
approved these changes
Apr 11, 2023
mkindahl
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 8afdddc added the first step for deprecating the old format of Continuous Aggregate but just for PostgreSQL 15 and later versions.
During the extension update we emit a message about the deprecation but this has being emited even if the user is using PostgreSQL versions before 15.
Fixed it by emiting the WARNING just when PostgreSQL version is greater or equal to 15.
Disable-check: force-changelog-changed