Copy job config JSONB structure into current MemoryContext #5807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jnidzwetzki, @konskov: please review this pull request.
|
akuzm
approved these changes
Jun 22, 2023
fabriziomello
approved these changes
Jun 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #5807 +/- ##
==========================================
+ Coverage 87.82% 87.86% +0.04%
==========================================
Files 239 239
Lines 55646 55649 +3
Branches 12320 12326 +6
==========================================
+ Hits 48872 48898 +26
+ Misses 4906 4879 -27
- Partials 1868 1872 +4
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
svenklemm
force-pushed
the
job_config
branch
2 times, most recently
from
bd3dabc
to
7dd576b
Compare
The job config jsonb can be a nested structure of elements that all need to reside in the same memory context as the other job values. To ensure this we copy the structure on assignment.
jnidzwetzki
added
the
force-auto-backport
jnidzwetzki
added a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Jun 27, 2023
This release contains bug fixes since the 2.11.0 release. We recommend that you upgrade at the next available opportunity. **Features** * timescale#5679 Teach loader to load OSM extension **Bugfixes** * timescale#5711 Scheduler accidentally getting killed when calling `delete_job` * timescale#5742 Fix Result node handling with ConstraintAwareAppend on compressed chunks * timescale#5750 Ensure tlist is present in decompress chunk plan * timescale#5754 Fixed handling of NULL values in bookend_sfunc * timescale#5798 Fixed batch look ahead in compressed sorted merge * timescale#5804 Mark cagg_watermark function as PARALLEL RESTRICTED * timescale#5807 Copy job config JSONB structure into current MemoryContext **Thanks** * @JamieD9 for reporting an issue with a wrong result ordering * @xvaara for reporting an issue with Result node handling in ConstraintAwareAppend
Merged
jnidzwetzki
added a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Jun 27, 2023
This release contains bug fixes since the 2.11.0 release. We recommend that you upgrade at the next available opportunity. **Features** * timescale#5679 Teach loader to load OSM extension **Bugfixes** * timescale#5705 Scheduler accidentally getting killed when calling `delete_job` * timescale#5742 Fix Result node handling with ConstraintAwareAppend on compressed chunks * timescale#5750 Ensure tlist is present in decompress chunk plan * timescale#5754 Fixed handling of NULL values in bookend_sfunc * timescale#5798 Fixed batch look ahead in compressed sorted merge * timescale#5804 Mark cagg_watermark function as PARALLEL RESTRICTED * timescale#5807 Copy job config JSONB structure into current MemoryContext **Thanks** * @JamieD9 for reporting an issue with a wrong result ordering * @xvaara for reporting an issue with Result node handling in ConstraintAwareAppend
jnidzwetzki
added a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Jun 27, 2023
This release contains bug fixes since the 2.11.0 release. We recommend that you upgrade at the next available opportunity. **Features** * timescale#5679 Teach loader to load OSM extension **Bugfixes** * timescale#5705 Scheduler accidentally getting killed when calling `delete_job` * timescale#5742 Fix Result node handling with ConstraintAwareAppend on compressed chunks * timescale#5750 Ensure tlist is present in decompress chunk plan * timescale#5754 Fixed handling of NULL values in bookend_sfunc * timescale#5798 Fixed batch look ahead in compressed sorted merge * timescale#5804 Mark cagg_watermark function as PARALLEL RESTRICTED * timescale#5807 Copy job config JSONB structure into current MemoryContext **Thanks** * @JamieD9 for reporting an issue with a wrong result ordering * @xvaara for reporting an issue with Result node handling in ConstraintAwareAppend
jnidzwetzki
added a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Jun 28, 2023
This release contains bug fixes since the 2.11.0 release. We recommend that you upgrade at the next available opportunity. **Features** * timescale#5679 Teach loader to load OSM extension **Bugfixes** * timescale#5705 Scheduler accidentally getting killed when calling `delete_job` * timescale#5742 Fix Result node handling with ConstraintAwareAppend on compressed chunks * timescale#5750 Ensure tlist is present in decompress chunk plan * timescale#5754 Fixed handling of NULL values in bookend_sfunc * timescale#5798 Fixed batch look ahead in compressed sorted merge * timescale#5804 Mark cagg_watermark function as PARALLEL RESTRICTED * timescale#5807 Copy job config JSONB structure into current MemoryContext * timescale#5824 Improve continuous aggregate query chunk exclusion **Thanks** * @JamieD9 for reporting an issue with a wrong result ordering * @xvaara for reporting an issue with Result node handling in ConstraintAwareAppend
jnidzwetzki
added a commit
that referenced
this pull request
Jun 28, 2023
This release contains bug fixes since the 2.11.0 release. We recommend that you upgrade at the next available opportunity. **Features** * #5679 Teach loader to load OSM extension **Bugfixes** * #5705 Scheduler accidentally getting killed when calling `delete_job` * #5742 Fix Result node handling with ConstraintAwareAppend on compressed chunks * #5750 Ensure tlist is present in decompress chunk plan * #5754 Fixed handling of NULL values in bookend_sfunc * #5798 Fixed batch look ahead in compressed sorted merge * #5804 Mark cagg_watermark function as PARALLEL RESTRICTED * #5807 Copy job config JSONB structure into current MemoryContext * #5824 Improve continuous aggregate query chunk exclusion **Thanks** * @JamieD9 for reporting an issue with a wrong result ordering * @xvaara for reporting an issue with Result node handling in ConstraintAwareAppend
jnidzwetzki
added a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Jun 28, 2023
This release contains bug fixes since the 2.11.0 release. We recommend that you upgrade at the next available opportunity. **Features** * timescale#5679 Teach loader to load OSM extension **Bugfixes** * timescale#5705 Scheduler accidentally getting killed when calling `delete_job` * timescale#5742 Fix Result node handling with ConstraintAwareAppend on compressed chunks * timescale#5750 Ensure tlist is present in decompress chunk plan * timescale#5754 Fixed handling of NULL values in bookend_sfunc * timescale#5798 Fixed batch look ahead in compressed sorted merge * timescale#5804 Mark cagg_watermark function as PARALLEL RESTRICTED * timescale#5807 Copy job config JSONB structure into current MemoryContext * timescale#5824 Improve continuous aggregate query chunk exclusion **Thanks** * @JamieD9 for reporting an issue with a wrong result ordering * @xvaara for reporting an issue with Result node handling in ConstraintAwareAppend
jnidzwetzki
added a commit
that referenced
this pull request
Jun 28, 2023
This release contains bug fixes since the 2.11.0 release. We recommend that you upgrade at the next available opportunity. **Features** * #5679 Teach loader to load OSM extension **Bugfixes** * #5705 Scheduler accidentally getting killed when calling `delete_job` * #5742 Fix Result node handling with ConstraintAwareAppend on compressed chunks * #5750 Ensure tlist is present in decompress chunk plan * #5754 Fixed handling of NULL values in bookend_sfunc * #5798 Fixed batch look ahead in compressed sorted merge * #5804 Mark cagg_watermark function as PARALLEL RESTRICTED * #5807 Copy job config JSONB structure into current MemoryContext * #5824 Improve continuous aggregate query chunk exclusion **Thanks** * @JamieD9 for reporting an issue with a wrong result ordering * @xvaara for reporting an issue with Result node handling in ConstraintAwareAppend
jnidzwetzki
added a commit
that referenced
this pull request
Jun 28, 2023
This release contains bug fixes since the 2.11.0 release. We recommend that you upgrade at the next available opportunity. **Features** * #5679 Teach loader to load OSM extension **Bugfixes** * #5705 Scheduler accidentally getting killed when calling `delete_job` * #5742 Fix Result node handling with ConstraintAwareAppend on compressed chunks * #5750 Ensure tlist is present in decompress chunk plan * #5754 Fixed handling of NULL values in bookend_sfunc * #5798 Fixed batch look ahead in compressed sorted merge * #5804 Mark cagg_watermark function as PARALLEL RESTRICTED * #5807 Copy job config JSONB structure into current MemoryContext * #5824 Improve continuous aggregate query chunk exclusion **Thanks** * @JamieD9 for reporting an issue with a wrong result ordering * @xvaara for reporting an issue with Result node handling in ConstraintAwareAppend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The job config jsonb can be a nested structure of elements that all need to reside in the same memory context as the other job values. To ensure this we copy the structure on assignment.