Improve cagg query chunk exclusion #5824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erimatnor, @pmwkaa: please review this pull request.
|
RafiaSabih
reviewed
Jun 27, 2023
svenklemm
force-pushed
the
cagg_exclusion
branch
from
41eb08b
to
fa19596
Compare
svenklemm
force-pushed
the
cagg_exclusion
branch
3 times, most recently
from
ce8dcce
to
61e8805
Compare
Codecov Report
@@ Coverage Diff @@
## main #5824 +/- ##
==========================================
- Coverage 87.87% 87.11% -0.77%
==========================================
Files 239 239
Lines 55698 55311 -387
Branches 12335 12209 -126
==========================================
- Hits 48945 48183 -762
+ Misses 4887 4831 -56
- Partials 1866 2297 +431
... and 105 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
svenklemm
force-pushed
the
cagg_exclusion
branch
3 times, most recently
from
ff12444
to
92dc54d
Compare
svenklemm
force-pushed
the
cagg_exclusion
branch
from
92dc54d
to
4bb126b
Compare
akuzm
approved these changes
Jun 28, 2023
svenklemm
force-pushed
the
cagg_exclusion
branch
from
4bb126b
to
9926462
Compare
erimatnor
reviewed
Jun 28, 2023
svenklemm
force-pushed
the
cagg_exclusion
branch
2 times, most recently
from
5e8ea99
to
ef1cb9a
Compare
jnidzwetzki
added a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Jun 28, 2023
This release contains bug fixes since the 2.11.0 release. We recommend that you upgrade at the next available opportunity. **Features** * timescale#5679 Teach loader to load OSM extension **Bugfixes** * timescale#5705 Scheduler accidentally getting killed when calling `delete_job` * timescale#5742 Fix Result node handling with ConstraintAwareAppend on compressed chunks * timescale#5750 Ensure tlist is present in decompress chunk plan * timescale#5754 Fixed handling of NULL values in bookend_sfunc * timescale#5798 Fixed batch look ahead in compressed sorted merge * timescale#5804 Mark cagg_watermark function as PARALLEL RESTRICTED * timescale#5807 Copy job config JSONB structure into current MemoryContext * timescale#5824 Improve continuous aggregate query chunk exclusion **Thanks** * @JamieD9 for reporting an issue with a wrong result ordering * @xvaara for reporting an issue with Result node handling in ConstraintAwareAppend
This patch changes the time_bucket exclusion in cagg queries to distinguish between < and <=. Previously those were treated the same leading to failure to exclude chunks when the constraints where exactly at the bucket boundary.
svenklemm
force-pushed
the
cagg_exclusion
branch
from
ef1cb9a
to
f216302
Compare
Merged
erimatnor
approved these changes
Jun 28, 2023
antekresic
approved these changes
Jun 28, 2023
erimatnor
reviewed
Jun 28, 2023
| return TimestampTzGetDatum(value); | ||
| } | ||
|
|
||
| elog(ERROR, "unsupported datatype in int_get_datum: %s", format_type_be(type)); |
There was a problem hiding this comment.
Still not sure why we have this error since it is impossible to reach here given the type check already outside this function. Also codecov is complaining. pg_unreachable() should be sufficient.
There was a problem hiding this comment.
This is a bit of a grey area. Code gets refactored all the time and conditions that are true now might not be later. I prefer to have an error here over just pg_unreachable because an error will only affect the session hitting this while pg_unreachable will kill all sessions and have postgres go into recovery.
jnidzwetzki
added a commit
that referenced
this pull request
Jun 28, 2023
This release contains bug fixes since the 2.11.0 release. We recommend that you upgrade at the next available opportunity. **Features** * #5679 Teach loader to load OSM extension **Bugfixes** * #5705 Scheduler accidentally getting killed when calling `delete_job` * #5742 Fix Result node handling with ConstraintAwareAppend on compressed chunks * #5750 Ensure tlist is present in decompress chunk plan * #5754 Fixed handling of NULL values in bookend_sfunc * #5798 Fixed batch look ahead in compressed sorted merge * #5804 Mark cagg_watermark function as PARALLEL RESTRICTED * #5807 Copy job config JSONB structure into current MemoryContext * #5824 Improve continuous aggregate query chunk exclusion **Thanks** * @JamieD9 for reporting an issue with a wrong result ordering * @xvaara for reporting an issue with Result node handling in ConstraintAwareAppend
jnidzwetzki
added a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Jun 28, 2023
This release contains bug fixes since the 2.11.0 release. We recommend that you upgrade at the next available opportunity. **Features** * timescale#5679 Teach loader to load OSM extension **Bugfixes** * timescale#5705 Scheduler accidentally getting killed when calling `delete_job` * timescale#5742 Fix Result node handling with ConstraintAwareAppend on compressed chunks * timescale#5750 Ensure tlist is present in decompress chunk plan * timescale#5754 Fixed handling of NULL values in bookend_sfunc * timescale#5798 Fixed batch look ahead in compressed sorted merge * timescale#5804 Mark cagg_watermark function as PARALLEL RESTRICTED * timescale#5807 Copy job config JSONB structure into current MemoryContext * timescale#5824 Improve continuous aggregate query chunk exclusion **Thanks** * @JamieD9 for reporting an issue with a wrong result ordering * @xvaara for reporting an issue with Result node handling in ConstraintAwareAppend
jnidzwetzki
added a commit
that referenced
this pull request
Jun 28, 2023
This release contains bug fixes since the 2.11.0 release. We recommend that you upgrade at the next available opportunity. **Features** * #5679 Teach loader to load OSM extension **Bugfixes** * #5705 Scheduler accidentally getting killed when calling `delete_job` * #5742 Fix Result node handling with ConstraintAwareAppend on compressed chunks * #5750 Ensure tlist is present in decompress chunk plan * #5754 Fixed handling of NULL values in bookend_sfunc * #5798 Fixed batch look ahead in compressed sorted merge * #5804 Mark cagg_watermark function as PARALLEL RESTRICTED * #5807 Copy job config JSONB structure into current MemoryContext * #5824 Improve continuous aggregate query chunk exclusion **Thanks** * @JamieD9 for reporting an issue with a wrong result ordering * @xvaara for reporting an issue with Result node handling in ConstraintAwareAppend
jnidzwetzki
added a commit
that referenced
this pull request
Jun 28, 2023
This release contains bug fixes since the 2.11.0 release. We recommend that you upgrade at the next available opportunity. **Features** * #5679 Teach loader to load OSM extension **Bugfixes** * #5705 Scheduler accidentally getting killed when calling `delete_job` * #5742 Fix Result node handling with ConstraintAwareAppend on compressed chunks * #5750 Ensure tlist is present in decompress chunk plan * #5754 Fixed handling of NULL values in bookend_sfunc * #5798 Fixed batch look ahead in compressed sorted merge * #5804 Mark cagg_watermark function as PARALLEL RESTRICTED * #5807 Copy job config JSONB structure into current MemoryContext * #5824 Improve continuous aggregate query chunk exclusion **Thanks** * @JamieD9 for reporting an issue with a wrong result ordering * @xvaara for reporting an issue with Result node handling in ConstraintAwareAppend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the time_bucket exclusion in cagg queries to distinguish between < and <=. Previously those were treated the same leading to failure to exclude chunks when the constraints where exactly at the bucket boundary.