Fix planner distributed table count #6113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gayyappan, @konskov: please review this pull request.
|
svenklemm
force-pushed
the
dist_table_count
branch
from
27149f1
to
6509392
Compare
The check for a distributed hypertable was done after ht had been changed to the compressed hypertable potentially leading to miscount or even segfault when the cache lookup for the compressed hypertable returned NULL.
svenklemm
force-pushed
the
dist_table_count
branch
from
6509392
to
c4b30c2
Compare
Codecov Report
@@ Coverage Diff @@
## main #6113 +/- ##
==========================================
+ Coverage 73.96% 81.51% +7.55%
==========================================
Files 246 246
Lines 49862 56730 +6868
Branches 12525 12568 +43
==========================================
+ Hits 36880 46244 +9364
- Misses 7128 8098 +970
+ Partials 5854 2388 -3466
... and 226 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
akuzm
approved these changes
Sep 25, 2023
|
Would it be possible to add a test for this fix? |
fabriziomello
approved these changes
Sep 26, 2023
Hmm I think a test that actually fails without the patch is probably quite complex to setup. At least I dont know of a quick way. |
konskov
added a commit
to konskov/timescaledb
that referenced
this pull request
Oct 9, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6113 Fix planner distributed table count * timescale#6117 Avoid decompressing batches using an empty slot * timescale#6123 Fix concurrency errors in OSM API * timescale#6142 do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
Merged
konskov
added a commit
to konskov/timescaledb
that referenced
this pull request
Oct 9, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6113 Fix planner distributed table count * timescale#6117 Avoid decompressing batches using an empty slot * timescale#6123 Fix concurrency errors in OSM API * timescale#6142 Do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
pallavisontakke
pushed a commit
to konskov/timescaledb
that referenced
this pull request
Oct 10, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6113 Fix planner distributed table count * timescale#6117 Avoid decompressing batches using an empty slot * timescale#6123 Fix concurrency errors in OSM API * timescale#6142 Do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
konskov
added a commit
to konskov/timescaledb
that referenced
this pull request
Oct 10, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6113 Fix planner distributed table count * timescale#6117 Avoid decompressing batches using an empty slot * timescale#6123 Fix concurrency errors in OSM API * timescale#6142 Do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
konskov
added a commit
that referenced
this pull request
Oct 10, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #6113 Fix planner distributed table count * #6117 Avoid decompressing batches using an empty slot * #6123 Fix concurrency errors in OSM API * #6142 Do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
konskov
added a commit
to konskov/timescaledb
that referenced
this pull request
Oct 10, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6113 Fix planner distributed table count * timescale#6117 Avoid decompressing batches using an empty slot * timescale#6123 Fix concurrency errors in OSM API * timescale#6142 Do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
konskov
added a commit
that referenced
this pull request
Oct 10, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #6113 Fix planner distributed table count * #6117 Avoid decompressing batches using an empty slot * #6123 Fix concurrency errors in OSM API * #6142 Do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
jnidzwetzki
pushed a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Nov 9, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6113 Fix planner distributed table count * timescale#6117 Avoid decompressing batches using an empty slot * timescale#6123 Fix concurrency errors in OSM API * timescale#6142 Do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
jnidzwetzki
pushed a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Nov 19, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6113 Fix planner distributed table count * timescale#6117 Avoid decompressing batches using an empty slot * timescale#6123 Fix concurrency errors in OSM API * timescale#6142 Do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for a distributed hypertable was done after ht had been changed to the compressed hypertable potentially leading to miscount or even segfault when the cache lookup for the compressed hypertable returned NULL.
Fixes #5966