Avoid decompressing batches using an empty slot #6117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jnidzwetzki, @gayyappan: please review this pull request.
|
When running COPY command into a compressed hypertable, we could end up using an empty slot for filtering compressed batches. This happens when a previously created copy buffer for a chunk does not contain any new tuples for inserting. The fix is to verify slots before attempting to do anything else.
Codecov Report
@@ Coverage Diff @@
## main #6117 +/- ##
==========================================
- Coverage 81.52% 81.45% -0.07%
==========================================
Files 246 246
Lines 56781 56737 -44
Branches 12588 12570 -18
==========================================
- Hits 46289 46214 -75
- Misses 8115 8132 +17
- Partials 2377 2391 +14
... and 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
antekresic
force-pushed
the
fix-empty-buffer
branch
from
19d1611
to
4a3f1ca
Compare
| @@ -0,0 +1,1002 @@ | |||
| generate_series,random | |||
There was a problem hiding this comment.
Is possible to use a small dataset?
There was a problem hiding this comment.
Not really, it needs at least 1001 rows in order to trigger this because of the sizes of copy buffers.
fabriziomello
approved these changes
Sep 26, 2023
svenklemm
approved these changes
Sep 26, 2023
jnidzwetzki
approved these changes
Sep 27, 2023
konskov
added a commit
to konskov/timescaledb
that referenced
this pull request
Oct 9, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6113 Fix planner distributed table count * timescale#6117 Avoid decompressing batches using an empty slot * timescale#6123 Fix concurrency errors in OSM API * timescale#6142 do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
Merged
konskov
added a commit
to konskov/timescaledb
that referenced
this pull request
Oct 9, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6113 Fix planner distributed table count * timescale#6117 Avoid decompressing batches using an empty slot * timescale#6123 Fix concurrency errors in OSM API * timescale#6142 Do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
pallavisontakke
pushed a commit
to konskov/timescaledb
that referenced
this pull request
Oct 10, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6113 Fix planner distributed table count * timescale#6117 Avoid decompressing batches using an empty slot * timescale#6123 Fix concurrency errors in OSM API * timescale#6142 Do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
konskov
added a commit
to konskov/timescaledb
that referenced
this pull request
Oct 10, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6113 Fix planner distributed table count * timescale#6117 Avoid decompressing batches using an empty slot * timescale#6123 Fix concurrency errors in OSM API * timescale#6142 Do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
konskov
added a commit
that referenced
this pull request
Oct 10, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #6113 Fix planner distributed table count * #6117 Avoid decompressing batches using an empty slot * #6123 Fix concurrency errors in OSM API * #6142 Do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
konskov
added a commit
to konskov/timescaledb
that referenced
this pull request
Oct 10, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6113 Fix planner distributed table count * timescale#6117 Avoid decompressing batches using an empty slot * timescale#6123 Fix concurrency errors in OSM API * timescale#6142 Do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
konskov
added a commit
that referenced
this pull request
Oct 10, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #6113 Fix planner distributed table count * #6117 Avoid decompressing batches using an empty slot * #6123 Fix concurrency errors in OSM API * #6142 Do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
jnidzwetzki
pushed a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Nov 9, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6113 Fix planner distributed table count * timescale#6117 Avoid decompressing batches using an empty slot * timescale#6123 Fix concurrency errors in OSM API * timescale#6142 Do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
jnidzwetzki
pushed a commit
to jnidzwetzki/timescaledb
that referenced
this pull request
Nov 19, 2023
This release contains bug fixes since the 2.12.0 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6113 Fix planner distributed table count * timescale#6117 Avoid decompressing batches using an empty slot * timescale#6123 Fix concurrency errors in OSM API * timescale#6142 Do not throw an error when deprecation GUC cannot be read **Thanks** * @symbx for reporting a crash when selecting from empty hypertables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running COPY command into a compressed hypertable, we could end up using an empty slot for filtering compressed batches. This happens when a previously created copy buffer for a chunk does not contain any new tuples for inserting. The fix is to verify slots before attempting to do anything else.