Add test for "compressed data is corrupt" in float8 compression #6689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6689 +/- ##
==========================================
+ Coverage 80.06% 81.50% +1.43%
==========================================
Files 190 191 +1
Lines 37181 36422 -759
Branches 9450 9465 +15
==========================================
- Hits 29770 29684 -86
+ Misses 2997 2972 -25
+ Partials 4414 3766 -648 ☔ View full report in Codecov by Sentry. |
jnidzwetzki
reviewed
Feb 22, 2024
jnidzwetzki
approved these changes
Feb 22, 2024
I think the fix is here, but haven't checked tbh: 4f2f658#diff-587fcbff3131f2ebe9b1a17f2bf8dfb532f92653fee332f8b6395ceb61eb0219R92 |
The bug itself is already fixed in the main branch.
akuzm
force-pushed
the
corrupt-float8
branch
from
ad83487
to
acc2e4a
Compare
For some reason I didn't realize then that this is an actual bug and we have to backport the fix :) |
mkindahl
approved these changes
Feb 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
The bug itself is already fixed in the main branch. (cherry picked from commit 94ac2bd)
jnidzwetzki
pushed a commit
that referenced
this pull request
Feb 28, 2024
The bug itself is already fixed in the main branch. (cherry picked from commit 94ac2bd)
timescale-automation
pushed a commit
that referenced
this pull request
Feb 28, 2024
The bug itself is already fixed in the main branch. (cherry picked from commit 94ac2bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug itself is already fixed in the main branch.
Fixes #6681
Disable-check: force-changelog-file