-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack name override #546
Merged
Merged
Stack name override #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onprem
reviewed
Aug 16, 2022
c7f1f22
to
bafc8fc
Compare
I plan on moving the |
d90afb9
to
917a439
Compare
@onprem let me know if you have any other questions about this. |
5 tasks
917a439
to
6fa0363
Compare
paulfantom
reviewed
Aug 18, 2022
paulfantom
suggested changes
Aug 18, 2022
6fa0363
to
b66acbc
Compare
- moving docs from inside the chart directory to the root level directory - updating upgrade documentation - updating doc links - bump chart version to 13.0.0
b66acbc
to
2fc7ab0
Compare
2 tasks
onprem
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the issue with
kube-prometheus-stack
not taking the Helm name given at install time.Which issue this PR fixes
Checklist