Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack name override #546

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Stack name override #546

merged 1 commit into from
Aug 22, 2022

Conversation

nhudson
Copy link
Contributor

@nhudson nhudson commented Aug 15, 2022

This will fix the issue with kube-prometheus-stack not taking the Helm name given at install time.

  • Updated upgrade documentation to make sure that if you are upgrading that you should most likely add the option back.

Which issue this PR fixes

Checklist

@nhudson nhudson self-assigned this Aug 15, 2022
@nhudson nhudson requested a review from a team as a code owner August 15, 2022 18:52
onprem
onprem reviewed Aug 16, 2022
View reviewed changes
chart/Chart.yaml Outdated Show resolved Hide resolved
chart/docs/upgrades.md Outdated Show resolved Hide resolved
@nhudson nhudson requested review from onprem and a team August 16, 2022 15:42
@nhudson
Copy link
Contributor Author

nhudson commented Aug 16, 2022

I plan on moving the chart/docs directory to be top level. This is due to ct, with any changes in the chart directory it will auto bump the version and for most/all docs we shouldn't need to do that.

@nhudson
Copy link
Contributor Author

nhudson commented Aug 16, 2022

@onprem let me know if you have any other questions about this.

@nhudson nhudson mentioned this pull request Aug 17, 2022
Merged
5 tasks
paulfantom
paulfantom reviewed Aug 18, 2022
View reviewed changes
chart/README.md Outdated Show resolved Hide resolved
paulfantom
paulfantom suggested changes Aug 18, 2022
View reviewed changes
chart/Chart.yaml Outdated Show resolved Hide resolved
@paulfantom paulfantom mentioned this pull request Aug 18, 2022
Open
@nhudson
fix so that kube-prometheus-stack name follows helm install
2fc7ab0 
  - moving docs from inside the chart directory to the root level directory
  - updating upgrade documentation
  - updating doc links
  - bump chart version to 13.0.0
@nhudson nhudson mentioned this pull request Aug 18, 2022
Merged
2 tasks
@nhudson nhudson enabled auto-merge August 18, 2022 18:33
onprem
onprem approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@onprem onprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@onprem onprem requested review from paulfantom and removed request for paulfantom August 22, 2022 13:03
@onprem onprem disabled auto-merge August 22, 2022 13:10
@onprem onprem merged commit 9ee4112 into timescale:main Aug 22, 2022
@nhudson nhudson deleted the stack_name_override branch August 22, 2022 13:21
@nhudson nhudson mentioned this pull request Sep 26, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfantom paulfantom paulfantom requested changes

@onprem onprem onprem approved these changes

Assignees

@nhudson nhudson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

name for kube-prometheus-stack is always overridden
3 participants
@nhudson @paulfantom @onprem