-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup connection to external TimescaleDB #531
Conversation
I wanted to be able to write a new |
d4b7ab6
to
6820622
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT about using promscale.connection.uri
in this test instead of dbName, user, password, host
combo? This way we could tackle #331 at the same time.
c649c1d
to
47d40b4
Compare
e2e tests are failing, but seem to be timing out when trying to setup the 2nd
|
Seems like the issue is with insufficient amount of resources:
Maybe for this particular test let's provision only one replica of prometheus and one replica of alertmanager by specifying it in chart/ci/externaldb-values.yaml |
Only merge after #546 |
@paulfantom I am interested how you saw this error? Also looks like that doesn't work either, this time the job has been running for hours now. |
I opened raw logs from one of the CI runs and it was there. However right now it is no longer present. |
1116c13
to
36ddee8
Compare
DO NOT merge until after #555 |
f207a9a
to
4031e16
Compare
- update and add documentation about how to connect to external db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Create a way to connect to and setup Grafana to query an external TimescaleDB if it's not provisioned by tobs.
You can now easily install tobs to connect to an external (to tobs) TimescaleDB. This can be achieved by setting
timescaledb-single.enabled=false
, setting the password for the TimescaleDBpostgres
role inpromscale.connection.password
, and the host URI for timescale inpromscale.connection.host
.This at minimum will setup Promscale and the Grafana datasource connections correctly to the external TimescaleDB.
Type of change
What type of changes does your code introduce to tobs? Put an
x
in the box that apply.CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)