Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

symengine==0.4.0 forestalls Python 3.8 usage #19

Closed
swight-prc opened this issue Nov 10, 2020 · 4 comments · Fixed by #20
Closed

symengine==0.4.0 forestalls Python 3.8 usage #19

swight-prc opened this issue Nov 10, 2020 · 4 comments · Fixed by #20

Comments

@swight-prc
Copy link
Contributor

Is there something about symengine>0.4.0 that breaks TimeSynth? Because this requirement keeps your library from being used in Python 3.8

I like your library, but I don't want to stay stuck in 3.7 if I can avoid it.
@swight-prc
Copy link
Contributor Author

FWIW, I cloned the repo and changed the dependency, and (at least for my purposes) everything still worked fine. I didn't run a comprehensive test.

@1Reinier
Copy link
Contributor

Good to hear—do you have a fork or PR somewhere? Then I can have Travis test it and merge it in.

@swight-prc
Copy link
Contributor Author

No, but I can push one when I get home from work today.

@swight-prc
Copy link
Contributor Author

All I did was change the dependency to symengine>=0.4.0, then install Timesynth and test my app (which uses like 3 things from ts). Pull request incoming, but heads up, it's not much.

@swight-prc swight-prc mentioned this issue Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change symengine requirement to >= instead of == swight-prc/TimeSynth
2 participants
@1Reinier @swight-prc