Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More idiomatic json format #40

Closed
timmahrt opened this issue Aug 27, 2022 · 3 comments
Closed

More idiomatic json format #40

timmahrt opened this issue Aug 27, 2022 · 3 comments

Comments

@timmahrt
Copy link
Owner

timmahrt commented Aug 27, 2022

The json format exported by praatio largely mirrors the textgrids, in terms of the data that is output.

As requested on a different github project, (MontrealCorpusTools/Montreal-Forced-Aligner#453) there isn't really any need to be bound by the textgrids. We should structure the json files to be their own thing.

Details can be found in the above link.

@timmahrt
Copy link
Owner Author

timmahrt commented Jan 8, 2023

@mmcauliffe Sorry to ping you. It's a bit late but I have a PR up with the new json format as we discussed about half a year ago 😅. If you have any concerns, please let me know. I was thinking of putting out the release next weekend or so.

@timmahrt
Copy link
Owner Author

timmahrt commented Feb 5, 2023

I've cut a release (that includes the changes to the json format)--praatio 6.0. I opened this issue, so I'll close it now, but feel free to reopen if there any comments.

@timmahrt timmahrt closed this as completed Feb 5, 2023
@mmcauliffe
Copy link
Contributor

Awesome, thanks for this! Sorry I didn't have a chance to look over it previously, but looks good to me, I saw the PR for updating to 6.0 on conda-forge, so going to be going through MFA making sure everything's compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants