Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure #5

Closed
fabaff opened this issue Mar 4, 2021 · 1 comment
Closed

Test failure #5

fabaff opened this issue Mar 4, 2021 · 1 comment

Comments

@fabaff
Copy link
Contributor

fabaff commented Mar 4, 2021

During the build process for the NixOS package, there is a test failure.

============================= test session starts ==============================
platform linux -- Python 3.8.8, pytest-6.1.2, py-1.9.0, pluggy-0.13.1
rootdir: /build/source
collected 2 items                                                              

tests/objects/test_device.py .                                           [ 50%]
tests/objects/test_location.py F                                         [100%]

=================================== FAILURES ===================================
________________________________ test_location _________________________________

location_fixture_response = {'comfortLevel': 0, 'configuration': {'faceRecognition': {'enabled': False, 'maxEtaPersons': 1, 'maxEtas': 2, 'maxPersons': 10, ...}}, 'country': 'GB', 'daylightSavingTimeEnabled': True, ...}

    def test_location(location_fixture_response):
        obj = LyricLocation(None, location_fixture_response)
        assert obj.locationID == location_fixture_response["locationID"]
        assert obj.name == location_fixture_response["name"]
        assert obj.country == location_fixture_response["country"]
        assert obj.zipcode == location_fixture_response["zipcode"]
        assert (
            obj.devices[0].displayedOutdoorHumidity
            == location_fixture_response["devices"][0]["displayedOutdoorHumidity"]
        )
        assert (
            obj.devices[0].vacationHold.enabled
            == location_fixture_response["devices"][0]["vacationHold"]["enabled"]
        )
>       assert (
            obj.devices[0].currentSchedulePeriod
            == location_fixture_response["devices"][0]["currentSchedulePeriod"]
        )
E       AssertionError: assert <aiolyric.objects.device.Currentscheduleperiod object at 0x7ffff5e349a0> == {'day': 'Monday', 'period': 'P2'}
E        +  where <aiolyric.objects.device.Currentscheduleperiod object at 0x7ffff5e349a0> = <aiolyric.objects.device.LyricDevice object at 0x7ffff5e348e0>.currentSchedulePeriod

tests/objects/test_location.py:22: AssertionError
=========================== short test summary info ============================
FAILED tests/objects/test_location.py::test_location - AssertionError: assert...
========================= 1 failed, 1 passed in 0.21s ==========================

I guess that this will happens to other consumers too.

@timmo001
Copy link
Owner

Fixed in 73bcb4e

@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants