Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Lyric.rooms_dict property has an incorrect type signature #67

Closed
apt-itude opened this issue Dec 3, 2023 · 0 comments · Fixed by #66
Closed

The Lyric.rooms_dict property has an incorrect type signature #67

apt-itude opened this issue Dec 3, 2023 · 0 comments · Fixed by #66

Comments

@apt-itude
Copy link
Contributor

Description

The _rooms_dict member is a nested dictionary of LyricRoom objects keyed by mac ID, then room ID, but the rooms_dict property that wraps it claims to return a type of dict[str, LyricRoom]. This causes type errors when using the client.

How to reproduce the issue (if applicable)

Use the rooms_dict property in a type-checked codebase.

Screenshots (if applicable)

Additional information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix type of rooms_dict property apt-itude/aiolyric
1 participant
@apt-itude