Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resolves #2061] [Binance] Add support for Stop-Limit orders #2062

Closed
wants to merge 1 commit into from

Conversation

tdiesler
Copy link
Contributor

No description provided.

@tdiesler tdiesler force-pushed the ghi2061 branch 4 times, most recently from 4406858 to 702c1c8 Compare December 30, 2017 15:57
@timmolter
Copy link
Member

Is a stop limit order different than a stop loss order (which is in the end a market order)?

@tdiesler
Copy link
Contributor Author

tdiesler commented Jan 1, 2018

Yes, it is different. Have a look at this

The enum already has STOP_LOSS, so it might get supported in the future. For now however I could not get it to work. The api docs are outdated.

@douggie
Copy link
Collaborator

douggie commented Jan 1, 2018 via email

@timmolter
Copy link
Member

timmolter commented Jan 1, 2018

OK, so if I understand this correctly, you can place a limit order along with a stop limit order at the same time? Is this essentially the same as placing 2 limit orders one after the other?

My gut feeling is that this should be a new class, perhaps one that extends LimitOrder, but I'm not yet sure either way.

@tdiesler
Copy link
Contributor Author

tdiesler commented Jan 1, 2018

Unfortunately, on Binance every order operates on a distinct set of coins. So you cannot place a sell order on all available coins and another sell order with different parameters on the same set of coins.

A stop-limit order is a two step process. When the market prices reaches the stop price, a limit order is placed with potentially a limit price that is different from the stop price.

@tdiesler
Copy link
Contributor Author

Closing in order to wait for other binance PRs

@tdiesler tdiesler closed this Jan 12, 2018
@tdiesler tdiesler deleted the ghi2061 branch January 16, 2018 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants