-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix amounts and add tests #12
Comments
|
Amounts fixed in 23ea70c The problem was that we had to use the "unscaled" amounts from the original edge here, as we explode to new unit processes. In contrast, the amounts from the timeline are scaled to match the FU. |
Additional problem came to my attention: What happens in our code atm is that we don't link from H2 to exploded versions of el-mix, but link directly to the different available version of this process in the background dbs via interpolation. However, if two of these interpolations point towards the same background process, the matrix entry we add gets overwritten each time. I'm pretty sure I talked about this with @cmutel at the Autumn School and he said that the default behavior of Datapackage.add_persistent_vector is to add the values instead of overwriting them - which seems to not be the case. |
Nvm, found the sum_inter_duplicates flag in bwp.create_datapackage() |
From the datapackage-creation-side, this should be fixed in b84644f |
Great! I will check the timestamps of the timeline. Still working on that, also in issue #5. |
The amounts just happened to work out because some exchange amounts were set to 1, so the interpolated shares had no influence on the total. We should also add tests checking if the Medusalca calculations are correct.
The text was updated successfully, but these errors were encountered: