Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #13218: avoid some irrelevant warnings for nim doc,rst2html,--app:lib, + other fixes #13550

Merged
merged 5 commits into from
Mar 13, 2020

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Mar 1, 2020

@timotheecour timotheecour changed the title fix #13218: avoid some irrelevant warnings for nim doc,rst2html fix #13218: avoid some irrelevant warnings for nim doc,rst2html,--app:lib, fixes some UnusedImport warnings etc Mar 1, 2020
@timotheecour timotheecour changed the title fix #13218: avoid some irrelevant warnings for nim doc,rst2html,--app:lib, fixes some UnusedImport warnings etc fix #13218: avoid some irrelevant warnings for nim doc,rst2html,--app:lib, + other fixes Mar 1, 2020
@timotheecour timotheecour force-pushed the pr_fix_warnings_hints branch 2 times, most recently from eca9791 to 3b224dd Compare March 3, 2020 07:36
compiler/commands.nim Outdated Show resolved Hide resolved
@timotheecour
Copy link
Member Author

timotheecour commented Mar 13, 2020

@Araq PTAL
your exportc suggestion is good, will do in a separate PR

EDIT: failure unrelated, and I'm fixing it in Vladar4/nimgame2#41

https://dev.azure.com/nim-lang/Nim/_build/results?buildId=3274&view=logs&jobId=f6c2f757-7152-5b00-b42b-aaebf1a063dd&j=f6c2f757-7152-5b00-b42b-aaebf1a063dd&t=f0f21f3f-4495-55c9-9119-ef53cf103fc2

FAIL: https://github.com/Vladar4/nimgame2/ C
Test "https://github.com/Vladar4/nimgame2/" in category "nimble-packages"
Failure: reBuildFailed
package test failed
$ nim c nimgame2/nimgame.nim
Hint: used config file 'd:\a\1\s\config\nim.cfg' [Conf]
Hint: used config file 'd:\a\1\s\config\config.nims' [Conf]
Hint: system [Processing]
...
Hint: streams [Processing]
d:\a\1\s\pkgstemp\nimgame2\nimgame2\utils.nim(169, 54) Warning: use `csize_t` instead; csize is deprecated [Deprecated]
d:\a\1\s\pkgstemp\nimgame2\nimgame2\utils.nim(169, 31) Error: type mismatch: got <ptr RWops, ptr char, csize, int literal(1000)>
but expected one of: 
proc rwRead(context: ptr RWops; p: pointer; size: csize_t; maxnum: csize_t): csize_t
  first type mismatch at position: 3
  required type for size: csize_t
  but expression 'csize(1)' is of type: csize

expression: rwRead(src, addr(result[r]), csize(1), 1000)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nim doc generates lots of false positive LockLevel warnings
2 participants