Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take RGB to sRGB conversion matrix from RAW instead of hardcoded one. #39

Closed
brotherofken opened this issue Apr 29, 2019 · 1 comment
Closed

Comments

@brotherofken
Copy link
Contributor

brotherofken commented Apr 29, 2019

Color convertion matrix hardcoded into srgb function will result in wrong white balance for almost all cameras other than Canon 5D III that Timothy was used in his work.

We should instead use camera's auto white balance that provided in imgdata.color.rgb_cam field.

For rare cases when this field is not available for some reason it's probably it's worth to implement some white balance method (e.g. gray world, convolutional color constancy).

This issue related to #36

@brotherofken
Copy link
Contributor Author

Closed due to #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant