Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"display" use a relative path to default ssh path #32

Closed
frozenkp opened this issue Apr 30, 2021 · 4 comments
Closed

"display" use a relative path to default ssh path #32

frozenkp opened this issue Apr 30, 2021 · 4 comments

Comments

@frozenkp
Copy link
Contributor

As title, when use "display" command, skm uses a relative path from default ssh path.
It shows an error like:

 % skm dp
Failed to read  ../.skm/github/id_rsa.pub
frozenkp added a commit to frozenkp/skm that referenced this issue Apr 30, 2021
@TimothyYe
Copy link
Owner

Hi @frozenkp, would you pls show me how to reproduce this issue?
I tried from my local machine with the latest version of SKM, it works without any issues.

@frozenkp
Copy link
Contributor Author

Hi,
I tested it on ubuntu 18.04.
I found that when "use" a key, it update the symbolic link in .ssh to a relative path of the key. (utils.go:180). When I use "display" command, it retrieves the links in .ssh folder and read it directly. (utils.go:263, actions.go:460)

image

@frozenkp
Copy link
Contributor Author

frozenkp commented Apr 30, 2021

Hi, I tried it on latest golang docker container and get the same problem.
Here is the asciinema record: https://asciinema.org/a/VSTRx2050KqnRq3KTNwcjH7CY

TimothyYe added a commit that referenced this issue Apr 30, 2021
@TimothyYe
Copy link
Owner

Thanks, I've already merged your changes, pls use the latest version v0.8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants