Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundler fails to run when trying to import acorn via terser #53

Closed
rotu opened this issue Sep 16, 2021 · 5 comments
Closed

Bundler fails to run when trying to import acorn via terser #53

rotu opened this issue Sep 16, 2021 · 5 comments

Comments

@rotu
Copy link

rotu commented Sep 16, 2021

Bundler is failing to run with a SyntaxError when trying to import acorn via terser.

Possibly related to terser/terser#1002

deno run --unstable --allow-all -r https://deno.land/x/bundler/spa_server_cli.ts

...

Check https://deno.land/x/bundler/spa_server_cli.ts
error: Uncaught SyntaxError: The requested module '/v51/acorn@8.5.0/deno/acorn.js' does not provide an export named 'default'
    at <anonymous> (https://cdn.esm.sh/v51/terser@5.7.1/deno/terser.js:2:172)
deno --version
deno 1.14.0 (release, aarch64-apple-darwin)
v8 9.4.146.15
typescript 4.4.2
@rotu rotu changed the title Bundler fails to run when trying to import acorn Bundler fails to run when trying to import acorn via terser Sep 16, 2021
@timreichen
Copy link
Owner

That seems to be a problem on the esm.sh side.

@ije
Copy link

ije commented Sep 18, 2021

@rotu i will fix this asap!

@ije
Copy link

ije commented Sep 18, 2021

@rotu can you pls try again?

@ije
Copy link

ije commented Sep 18, 2021

@timreichen can you please add some testings in esm.sh ensure this not happen again? for example: https://github.com/alephjs/esm.sh/blob/master/test/deno/common/terser.test.ts

@rotu
Copy link
Author

rotu commented Sep 22, 2021

Thank you, @ije! I can verify this is fixed

@rotu rotu closed this as completed Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants