Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redevelop tests #71

Closed
timtrice opened this issue Jun 9, 2017 · 1 comment
Closed

Redevelop tests #71

timtrice opened this issue Jun 9, 2017 · 1 comment
Labels
High Priority NOW NOW NOW Icebox Issues delayed by outside influence

Comments

@timtrice
Copy link
Contributor

timtrice commented Jun 9, 2017

The current tests as they stand just take too long. In part, this is because some datasets get hit repeatedly (accessing annual datasets to retrieve individual storm data). But the slowest by far are the forecast/advisory tests. These have been trimmed down but they still take a bit of time.

The forecast/advisory tests should be expanded. A concern is modifiying a regex pattern to fit an issue for a specific advisory but consequentially breaking it for another advisory; there are many inconsistencies in these products. At this point of time there is no real way to know that patching one bug will not open up another. That's an issue.

I'm opening this issue to start noting ideas and methods to redevelop the tests. The time issue isn't going to get better; it just is what it is. But the tests needs to be redeveloped to accomodate the issues noted above and streamline the tests as much as possible.

@timtrice timtrice added Icebox Issues delayed by outside influence High Priority NOW NOW NOW labels Jun 9, 2017
This was referenced Jun 10, 2017
@timtrice
Copy link
Contributor Author

Many tests were removed during development of hotfix/v0.2.0-6. Some are ok as they tested functions that no longer exist.

However, tests removed in commit dea1060] need to be re-added. Unsure at the moment why they were failling. When ran tests check they failed. But if ran from script or console they passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority NOW NOW NOW Icebox Issues delayed by outside influence
Projects
None yet
Development

No branches or pull requests

1 participant