Skip to content
This repository has been archived by the owner on Dec 28, 2022. It is now read-only.

Feature: Beep when song is changed via headset button #24

Closed
faho opened this issue Feb 26, 2017 · 1 comment
Closed

Feature: Beep when song is changed via headset button #24

faho opened this issue Feb 26, 2017 · 1 comment

Comments

@faho
Copy link
Contributor

faho commented Feb 26, 2017

One feature from Vanilla Music I really like is the option to beep when I change songs via double-pressing my headset's button.

The reason for this is that, with songs often starting with a few seconds of silence or fade-in, it's difficult to tell if I've paused or skipped.

Since both applications are GPLv3, you might be able to crib parts of their implementation - see https://github.com/vanilla-music/vanilla/blob/master/src/ch/blinkenlights/android/vanilla/MediaButtonReceiver.java.

@timusus
Copy link
Owner

timusus commented Feb 27, 2017

I think this is a great idea. Obviously needs to be optional though. I'd use this myself.

faho added a commit to faho/Shuttle that referenced this issue Feb 27, 2017
This is nice because telling the difference between paused playback and a song that starts with silence can be tricky.

This was inspired by the implementation in vanilla music (also GPLv3) and the beep sound was taken from there.

Fixes timusus#24.
faho added a commit to faho/Shuttle that referenced this issue Feb 27, 2017
This is nice because telling the difference between paused playback and a song that starts with silence can be tricky.

This was inspired by the implementation in vanilla music (also GPLv3) and the beep sound was taken from there.

Fixes timusus#24.
@timusus timusus closed this as completed Feb 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants