Add support for parsing standard Xorg.log output #46
Conversation
|
FWIW the failing test is "ERROR: test_valid (frontend.selenium_tests.test_upload.UploadSeleniumTestCase)" which fails with a timeout. I don't think that's a result of anything done in this commit. |
| @@ -52,6 +52,11 @@ <h4>Thanks!</h4> | |||
| <input type="radio" id="id_text_type_xrandr" name="text_type" value="xrandr"{% ifequal form.text_type.value 'xrandr' %} checked{% endifequal %}> XRandR | |||
| </label> | |||
| <p>Linux users, run <code>xrandr --props</code> and paste its output.</p> | |||
| <label class="radio"> | |||
| <input type="radio" id="id_text_type_xoglog" name="text_type" value="xorglog"{% ifequal form.text_type.value 'xorglog' %} checked{% endifequal %}> Xorg.log | |||
There was a problem hiding this comment.
"id_text_type_xoglog" maybe meant ...xorglog?
There was a problem hiding this comment.
Maybe :) Fixed, but FWIW I don't think this has any practical implications on implementation.
|
Hm, actually I can reproduce that selenium failure locally. I'll figure out what's going on. The binary upload gets a 500 error. |
|
Ugh, the error is caused by frontend/views.py:123 doing edid_object.save() which results in a 'database table is locked: frontend_edid" error. Clearly not caused by my change (reproduced same thing on master), so must be a change in django or sqlite driver. |
Looks like something in selenium has changed, but this code was dubious to begin with. upload-id-upload is not a form but rather a (submit) button. I suspect that the "submit" action was causing a click *and* a submit at the same time, so two requests were getting dispatched, causing a deadlock in sqlite. The fix would either be to submit the form, or simply click on the button. The latter is chosen to avoid any unnecessary changes.
There's a wealth of xorg.log files posted for various debug purposes. Make it easy to import data from these. This output is produced by hw/xfree86/ddc/print_edid.c so all DDX's should produce the same output.
There's a wealth of xorg.log files posted for various debug purposes.
Make it easy to import data from these.
This output is produced by hw/xfree86/ddc/print_edid.c so all DDX's
should produce the same output.