-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore git exceptions #20
Conversation
Hi @Guts, Thanks for the PR! Lot of different improvements here. The different changes make it a little bit harder to review. I would appreciate for next time a separate PR for things like 8f771b2.
I think it should when this plugin is enabled (PEP20):
To be honest I have been struggling a bit with the fallback option when git is not available. Because the fallback is not longer the last revision date, but rather the last build date. This was confusing to users, because the dates might change depending on where you build your docs. Case in point: #10 After reviewing your PR I agree the cleanest way to deal with this is to be explicit about it with an option. I do think we should improve the naming of the parameter |
Hi @timvink
Thank you for your plugin, it's really well done and useful 👍
You're completely right. These changes are due to my automatic Python setup with pre-commit. I realized that and besides, my other pull requests are more 'atomic'. If you prefer I can rollback on blacking and others EOF fixes, and only push the feature.
Yeah I was not really inspired about the option name. Feel free to rename it with your idea. |
Thanks, happy the plugin is useful for others as well :)
No need.
I don't have a lot of time today. If you'd like this merged quickly I'd appreciate some help with renaming to |
Here, confined = plenty of time to contribute to projects I use :) |
Looks good, thanks for all the work! I'll wait for the other two PR's to complete because releasing a new version to PyPi |
Released |
Actual behavior
As specified in the readme:
In certain cases (development phases, content edited by non developers...) where git is not installed or can't read files, it prevents the workflow.
By the way, the build should not fail because of a lack of third-party software.
Proposal
This PR adds an option to ignore git errors: