-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use locale during date formatting #22
Conversation
Good catch! Can you have a look at the failing tests? |
Yeah I'm on it but I'm not sure why they are failing because I can build in strict mode 🤔 |
Let me know if you want me to have a look |
Got it. Tests are comparing localized dates with no localized dates because mkdocs-git-revision-date-localized-plugin/tests/test_basic.py Lines 153 to 158 in 2f8dc73
|
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
- Coverage 92.59% 86.45% -6.14%
==========================================
Files 2 2
Lines 81 96 +15
==========================================
+ Hits 75 83 +8
- Misses 6 13 +7
Continue to review full report at Codecov.
|
@timvink I had to rewrite a part of test and plugin (on_config method) to get a clearer view on why tests were failing. Finally it's just a problem with the regex used to match rendered date, only on Windows. |
Fixed setting the encoding in read_text method. |
@timvink sorry for the mess, but I was stuck with tests running which were no handling the locale value. Now, it's good and, I hope, a bit better ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for extending the tests! I have just a couple of comments :)
Thanks again @Guts 🎉 |
Close #21 with consequences on test: