Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal use of JsonKeysetWriter, which is deprecated #34

Closed
ahyatt-continua opened this issue May 22, 2024 · 2 comments
Closed

Internal use of JsonKeysetWriter, which is deprecated #34

ahyatt-continua opened this issue May 22, 2024 · 2 comments
Assignees

Comments

@ahyatt-continua
Copy link

At _json_proto_keyset_format.py:83 (in my 1.10 Python Tink, and also in your repository in HEAD), you use JsonKeysetWriter, which is deprecated.

I don't think a library should be printing out deprecation warnings about internal usage of deprecated functions, since users have no way of fixing it.

Also, it's a bit worrying: is the deprecation something I, as a user, need to be concerned about?

I think either fixing the use (using the replacement suggested in the JsonKeysetWriter class), or simply removing the warning would be a good fix for this issue.

@juergw
Copy link
Contributor

juergw commented Jun 19, 2024

I agree, I removed the warning.

@juergw
Copy link
Contributor

juergw commented Jun 19, 2024

Here: 71752ea

@juergw juergw self-assigned this Jun 19, 2024
@juergw juergw closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants