-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wget https://s.gianarb.it/hook/hook-master.tar.gz throws 404 #45
Comments
Take image push option from the outside
@thebsdbox Is there an updated link where folks should expect to find the latest build of Hook? |
In the releases! 🤩 |
Would it make sense to update the README here with a link to the latest release tarball? I can open a PR if you think that would be sensible.
I think we might want to first conclude and merge that PR and then optionally set up a GitHub Workflow (or equivalent) for building and releasing a tarball on git tag events (or similar). What do you all think? Thanks. |
Yeah, i'm really behind at the moment juggling a few things i'll try and complete this bit of work tomorrow and stabilise the whole thing. |
@thebsdbox - any update? If you are still swamped: someone else could take this on if you describe what changes you were planning to make. |
I'm still new here, but I'm not sure I understand what work is necessary to close this issue. Some questions:
At this point, does this issue boil down to fixing the "How to use hook with Sandbox" documentation in the README to be accurate again? I noticed it also references a |
I'm currently (AS we speak) building the ARM release.. it just takes a long time on x86. |
I can see that @thebsdbox has merged #70 GG! 🎉 Also we now have tarballs for both ARM64 and x86_64 in the latest release: https://github.com/tinkerbell/hook/releases/tag/5.10.57. So to your points @tstromberg:
|
I believe that this particular issue can be closed.. the problem that I think we have is that building a kernel with GitHub actions usually times out, especially with the cross compile builds. There already exists a PR from @detiber for this work. |
Any objections to closing this out, @markyjackson-taulia? |
@damdo if you think this ticket is still unresolved, then we should probably update the title and description. The sandbox now uses Hook out of the box, and I don't currently see mention of the URL in the title of this ticket in the README file. |
I agree with you here. There is no more mentions of this in the README and Hook is now the default in sandbox so no more need to do most of the things I was suggesting here: #45 (comment) |
Yes, close it and thank you |
Expected Behaviour
tar should be available
Current Behaviour
404
The text was updated successfully, but these errors were encountered: