-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boots should not PXE if no workflow defined #35
Comments
Instead of being a noop I would like to be able to specify a workflow for the machines that do not (yet) have a workflow. That way I can deal with them (e.g. run some kind of inventory application on them and show the machine in some kind of "un-provisioned/new" machines catalog). |
@rgl Agreed this would be a good capability to create a default "wait-for-work" template + container that comes baked with Tinkerbell. We also need this in Packet, and I think would have broad appeal. Perhaps we can capture that in a separate issue. |
Updates so far. -) Development & Testing activity:
I have raised below PR, for workflow client changes in boots and tink. Later, i will add my other changes in same branch. |
…orkflow for a hardware
Tested this PR along with tinkerbell/tink#200.
|
…orkflow for a hardware
cherry-picked commits Added unit test and modified name of tink clients Added go.mod file added review comment changes addressed review comments Adressed review comments fixed comment in endpoint Addressed review comments Solved linting errors and addressed review comments removed fetch workflow logic from dhcp serve modified call to workflowSvcClient minor changes added unit test for GetWorkflowFromTink addressed review comments
## Details No pxe boot is to be supported if there are no active workflow for a worker/hardware. ## Changes Added endpoint to fetch active workflow for a hardware Added logic to translate hardware id to active worker id Added logic to stop pxe boot if not active workflow is present. ## Testing Tested with client added via tinkerbell/tink#200. happy path testing completed. `{"level":"info","ts":1593695857.2480636,"caller":"job/job.go:55","msg":"found active workflow for hardware 0eba0bf8-3772-4b4a-ab9f-6ebe93b90a94 with workflow id d0f730bc-894d-42de-8c37-9e423f5c761d","service":"github.com/tinkerbell/boots","pkg":"http","dhcp":"0eba0bf8-3772-4b4a-ab9f-6ebe93b90a94"}` Need to do testing with new tink after the merge of above mentioned PR. Negative testing pending.
If there is no active workflow for a worker, boots should not PXE boot a system. Right now, it will always PXE into the environment and noop, which is not a practical use case.
The text was updated successfully, but these errors were encountered: