Added workflow client to connect to tink. Boots issue #35 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cbkhare
added
kind/feature
|
Testing completed with tinkerbell/smee@96bb35d Moving PR for review. |
This was referenced Jul 2, 2020
|
couple of changes, during this Fix were identified related to naming of some methods, since those methods were not part of the workflow, separate issue is created #206 . |
mergify bot
added a commit
to tinkerbell/smee
that referenced
this pull request
Jul 17, 2020
## Details No pxe boot is to be supported if there are no active workflow for a worker/hardware. ## Changes Added endpoint to fetch active workflow for a hardware Added logic to translate hardware id to active worker id Added logic to stop pxe boot if not active workflow is present. ## Testing Tested with client added via tinkerbell/tink#200. happy path testing completed. `{"level":"info","ts":1593695857.2480636,"caller":"job/job.go:55","msg":"found active workflow for hardware 0eba0bf8-3772-4b4a-ab9f-6ebe93b90a94 with workflow id d0f730bc-894d-42de-8c37-9e423f5c761d","service":"github.com/tinkerbell/boots","pkg":"http","dhcp":"0eba0bf8-3772-4b4a-ab9f-6ebe93b90a94"}` Need to do testing with new tink after the merge of above mentioned PR. Negative testing pending.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added method which interfaces a client to work with workflows in tink.
Why is this needed
Boots needs to connect to tink to get details for the workflow.
Testing completed.
Cross tested cli with PR tinkerbell/smee@96bb35d