Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup tinkerbell stack locally using Vagrant #165

Merged
merged 12 commits into from
Jun 17, 2020
Merged

Setup tinkerbell stack locally using Vagrant #165

merged 12 commits into from
Jun 17, 2020

Conversation

gauravgahlot
Copy link
Contributor

@gauravgahlot gauravgahlot commented Jun 8, 2020 •
edited by grahamc

Vagrant providers supported:

  • libvirt
  • virtualbox

Known issues with virtualbox:

  • Worker: Vagrant stuck with connection timeout retrying (related thread)

Signed-off-by: Gaurav Gahlot gaurav.gahlot19@gmail.com

@gauravgahlot gauravgahlot added kind/feature Categorizes issue or PR as related to a new feature. area/setup Issue related to tinkerbell setup labels Jun 8, 2020
@gauravgahlot gauravgahlot self-assigned this Jun 8, 2020
@gauravgahlot gauravgahlot linked an issue Jun 8, 2020 that may be closed by this pull request
Add support to setup tinkerbell stack locally using Vagrant #166
Closed
2 tasks
@mrmrcoleman mrmrcoleman added this to Blocked in Issues List Jun 9, 2020
@gauravgahlot gauravgahlot mentioned this pull request Jun 9, 2020
Closed
@nathangoulding nathangoulding moved this from Blocked to In Progress in Issues List Jun 9, 2020
@gauravgahlot gauravgahlot added the do-not-merge Signal to Mergify to block merging of the PR. label Jun 10, 2020
alexellis
alexellis reviewed Jun 16, 2020
View reviewed changes
Copy link
Contributor

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of thoughts

deploy/vagrant/Vagrantfile Outdated Show resolved Hide resolved
deploy/vagrant/scripts/tinkerbell.sh Show resolved Hide resolved
@grahamc grahamc removed the do-not-merge Signal to Mergify to block merging of the PR. label Jun 17, 2020
grahamc
grahamc previously approved these changes Jun 17, 2020
View reviewed changes
@alexellis
Copy link
Contributor

Known issues: Kibana is not reachable

Why?

@grahamc
Copy link
Contributor

grahamc commented Jun 17, 2020

I removed that known issue from the description, as Kibana is no longer installed.

@grahamc grahamc added the ready-to-merge Signal to Mergify to merge the PR. label Jun 17, 2020
gauravgahlot and others added 12 commits June 17, 2020 16:17
@grahamc grahamc removed the ready-to-merge Signal to Mergify to merge the PR. label Jun 17, 2020
@grahamc grahamc added the ready-to-merge Signal to Mergify to merge the PR. label Jun 17, 2020
@grahamc grahamc merged commit db1c9c2 into tinkerbell:master Jun 17, 2020
Issues List automation moved this from In Progress to Just shipped Jun 17, 2020
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgl rgl rgl left review comments

@alexellis alexellis alexellis left review comments

@grahamc grahamc grahamc approved these changes

Assignees

@gauravgahlot gauravgahlot

Labels
area/setup Issue related to tinkerbell setup kind/feature Categorizes issue or PR as related to a new feature.
Projects
No open projects
Issues List
  
Just shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to setup tinkerbell stack locally using Vagrant
5 participants
@gauravgahlot @alexellis @grahamc @rgl @mmlb