Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose: remove EFK #170

Merged
merged 1 commit into from
Jun 16, 2020
Merged

docker-compose: remove EFK #170

merged 1 commit into from
Jun 16, 2020

Conversation

grahamc
Copy link
Contributor

@grahamc grahamc commented Jun 15, 2020

docker-compose: remove EFK

Fetching EFK adds several minutes to the setup time and start-times.

I think most hackers will want to just see the logs on the console,
and be interested in EFK once things are more prod-like. Using EFK
means the user actually has to do some initial config on their
cluster, and it doesn't just work out of the box.

One problem is OSIE wants to talk specifically to ElasticSearch, but
I wonder if we could swap it out with syslog and a syslog listener?

@grahamc grahamc force-pushed the remove-elk branch 3 times, most recently from a9e0929 to 982ea73 Compare June 15, 2020 20:06
@grahamc
Copy link
Contributor Author

grahamc commented Jun 15, 2020

Unfortunately we have this to reckon with: https://github.com/tinkerbell/osie/blob/master/installer/workflow-helper.sh#L60-L62

@grahamc
Copy link
Contributor Author

grahamc commented Jun 15, 2020

I got a general 👍 from @mmlb. We should probably adjust the OSIE workflow helper to stop using fluentbit, and just use syslog like ipxe does:

https://github.com/tinkerbell/boots/blob/master/ipxe/dhcp_options.go#L68

and like the entrypoint of osie already does:

[grahamc@Petunia:~/projects/github.com/tinkerbell]$ cat ./osie/docker/entrypoint.sh
...
echo "Logging to $RLOGHOST with $container_uuid"
# we tee to fd3 so that output can go out on stdout instead stderr
exec 3>&1
exec 2> >(tee /proc/self/fd/3 | logger -n "$RLOGHOST" -P 514 -t "$container_uuid")
exec 1>&2

Copy link
Contributor

@mmlb mmlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending ELK -> EFK and missing word in PR message see the logs on the, a

Fetching EFK adds several minutes to the setup time and start-times.

I think most hackers will want to just see the logs on the console,
and be interested in EFK once things are more prod-like. Using EFK
means the user actually has to do some initial config on their
cluster, and it doesn't just work out of the box.

One problem is OSIE wants to talk specifically to ElasticSearch, but
I wonder if we could swap it out with syslog and a syslog listener?
@grahamc
Copy link
Contributor Author

grahamc commented Jun 16, 2020

fixup'd, @mmlb !

@mmlb mmlb changed the title docker-compose: remove ELK and FluentBit docker-compose: remove EFK and FluentBit Jun 16, 2020
@mmlb mmlb changed the title docker-compose: remove EFK and FluentBit docker-compose: remove EFK Jun 16, 2020
@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label Jun 16, 2020
@grahamc grahamc removed the request for review from gauravgahlot June 16, 2020 15:37
@mergify mergify bot merged commit ffd50a5 into tinkerbell:master Jun 16, 2020
@grahamc grahamc deleted the remove-elk branch June 16, 2020 15:39
@alexellis
Copy link
Contributor

( The description still says EFK instead of ELK )

@alexellis
Copy link
Contributor

Have you made this an option or removed it completely as I consumed the logs API of elastic search in tinkerbot for the /logs command

@alexellis
Copy link
Contributor

One thing to bear in mind is that log collection is hard when working on PCs in the lab where there is no serial output. The only way I was able to get output was by searching in ElasticSearch when doing this on a regular PC. Is this PR taking that away?

@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants