Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 4G memory for worker to prevent OOM errors when booting OSIE #188

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Added 4G memory for worker to prevent OOM errors when booting OSIE #188

merged 1 commit into from
Jun 24, 2020

Conversation

mrmrcoleman
Copy link
Contributor

Intended to address #181 by simply upping the amount of memory on the worker.

@mrmrcoleman mrmrcoleman changed the title Added 4G memory for worker machine to prevent OOM errors when booting OSIE Added 4G memory for worker to prevent OOM errors when booting OSIE Jun 23, 2020
@mrmrcoleman mrmrcoleman mentioned this pull request Jun 23, 2020
Closed
@mrmrcoleman mrmrcoleman added this to Blocked in Issues List Jun 23, 2020
@mrmrcoleman mrmrcoleman moved this from Blocked to In Progress in Issues List Jun 24, 2020
alexellis
alexellis approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this change, LGTM. Please can we get it merged?

@alexellis
Copy link
Contributor

@gianarb do you have merge access?

@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Jun 24, 2020
@mergify mergify bot merged commit 09c2c91 into tinkerbell:master Jun 24, 2020
Issues List automation moved this from In Progress to Just shipped Jun 24, 2020
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianarb gianarb gianarb approved these changes

@alexellis alexellis alexellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Issues List
  
Just shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mrmrcoleman @alexellis @gianarb @mmlb