Merge hardware and target. #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parauliya
added
kind/feature
gauravgahlot
removed
the
do-not-merge
parauliya
force-pushed
the
remove_target
branch
from
b53f5a5
to
df59f0e
Compare
Now while creating a workflow you can directly provide hardware/devices mac addr. And now there is no need of targets.
Signed-off-by: Gaurav Gahlot <gaurav.gahlot19@gmail.com>
Signed-off-by: Gaurav Gahlot <gaurav.gahlot19@gmail.com>
parauliya
changed the title
gauravgahlot
suggested changes
May 6, 2020
gauravgahlot
reviewed
May 6, 2020
parauliya
requested review from
gauravgahlot
and removed request for
nathangoulding
gauravgahlot
approved these changes
May 9, 2020
This was referenced May 13, 2020
|
Does this mean that the target creation is no longer required? |
mmlb
pushed a commit
to mmlb/tinkerbell-tink
that referenced
this pull request
May 21, 2020
* Merged hardware and target. Now while creating a workflow you can directly provide hardware/devices mac addr. And now there is no need of targets. * using hello-world as the first example Signed-off-by: Gaurav Gahlot <gaurav.gahlot19@gmail.com> * fixes Signed-off-by: Gaurav Gahlot <gaurav.gahlot19@gmail.com> * moved comments out of data JSON Signed-off-by: Gaurav Gahlot <gaurav.gahlot19@gmail.com> * Changed the way of writing template and creating workflow * Updating the docs with current implementation * Incorporated some minor review comments Co-authored-by: Gaurav Gahlot <gaurav.gahlot19@gmail.com>
parauliya
added a commit
to infracloudio/tink
that referenced
this pull request
May 22, 2020
* Merged hardware and target. Now while creating a workflow you can directly provide hardware/devices mac addr. And now there is no need of targets. * using hello-world as the first example Signed-off-by: Gaurav Gahlot <gaurav.gahlot19@gmail.com> * fixes Signed-off-by: Gaurav Gahlot <gaurav.gahlot19@gmail.com> * moved comments out of data JSON Signed-off-by: Gaurav Gahlot <gaurav.gahlot19@gmail.com> * Changed the way of writing template and creating workflow * Updating the docs with current implementation * Incorporated some minor review comments Co-authored-by: Gaurav Gahlot <gaurav.gahlot19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now while creating a workflow you can directly provide hardware/devices mac addr.
And now there is no need of targets. This approach will support both single and multiple workers as well:
Current
templatelook like this forworkerfield: ( Has theTargetreference )worker: "{{index .Targets "machine1" "mac_addr"}}"After this PR the
templatewill look like this forworkerfield: (Targetreference not required)worker: {{.device_1}}Right Now the
workflow createcommand is as follows for single and multiple worker: ( Has theTargetreference )tink workflow create -t <temp-id> -r <target-id>After this PR the
workflow createcommand it will look like: (Targetreference not required )For single worker
tink workflow create -t <template_id> -r '{ "device_1": "mac/IP/Id" }'For Multiple worker you can just increase the key value pair in the workflow create command:
tink workflow create -t <template_id> -r '{ "device_1": "mac/IP", "device_2": "mac/IP"}'Note: In the above case user can replace the keys device_1/device_2 with any name which should contain only
letters, numbers and Underscoreand should be in sync with template.