Skip to content

Fix bug with hardcoded frequency in PytorchForecastingTransform #107

Merged
merged 8 commits into from
Sep 28, 2021

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Sep 28, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

#106.

Closing issues

Closes #106.

…d notes about position sensitivity of transform, write tests
@Mr-Geekman Mr-Geekman added bug Something isn't working documentation Improvements or additions to documentation labels Sep 28, 2021
@Mr-Geekman Mr-Geekman self-assigned this Sep 28, 2021
@Mr-Geekman Mr-Geekman changed the title Fix bug with hardcoded frequency in PytorchForecastingTransformer Fix bug with hardcoded frequency in PytorchForecastingTransform Sep 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #107 (5b3364e) into master (d45201d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   87.77%   87.79%   +0.02%     
==========================================
  Files          54       54              
  Lines        2478     2483       +5     
==========================================
+ Hits         2175     2180       +5     
  Misses        303      303              
Impacted Files Coverage Δ
etna/transforms/pytorch_forecasting.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45201d...5b3364e. Read the comment docs.

@Mr-Geekman Mr-Geekman marked this pull request as ready for review September 28, 2021 12:12
Notes
-----
This transform should be added at the very end of `transforms` parameter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should raise Exception?

Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martins0n martins0n merged commit 262fa68 into master Sep 28, 2021
@martins0n martins0n deleted the issue-106 branch September 28, 2021 14:35
iKintosh pushed a commit that referenced this pull request Oct 7, 2021
* Fix bug with hardcoded frequency in PytorchForecastingTransformer, add notes about position sensitivity of transform, write tests

(cherry picked from commit 262fa68)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded frequency in PytorchForecastingTransform
3 participants