-
Notifications
You must be signed in to change notification settings - Fork 81
Add cap and floor to prophet regressor columns #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
- Coverage 90.49% 85.80% -4.70%
==========================================
Files 45 45
Lines 2010 2015 +5
==========================================
- Hits 1819 1729 -90
- Misses 191 286 +95
Continue to review full report at Codecov.
|
iKintosh
previously approved these changes
Sep 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
etna/models/prophet.py
Outdated
for column_name in columns: | ||
if column_name.startswith("regressor"): | ||
regressors_columns.append(column_name) | ||
elif column_name == "cap": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
elif column_name in ["cap", "floor"]:
regressors_columns.append(column_name)
❓
shouldn't it be |
* Create CHANGELOG.md * Add version 1.0.0 * add unreleased changes
* fix tsdataset getitem method * fix style * add test for all indexes * fix imports * add Nan info * fix typo Co-authored-by: an.alekseev <an.alekseev@tinkoff.ru>
* Add micro and macro mode for ScalerTransform * Add macro/micro mode for power transformers Co-authored-by: a.p.chikov <a.p.chikov@macbook-a.p.chikov>
This reverts commit 8c60bba.
…in documentation about it
# Conflicts: # CHANGELOG.md
julia-shenshina
approved these changes
Sep 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (checklist)
make lint
(poetry install -E style
).pytest tests/
?Type of Change
Proposed Changes
Related Issue
#58.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Closing issues
Closes #58.