Skip to content

Add cap and floor to prophet regressor columns #62

Merged
merged 13 commits into from
Sep 22, 2021
Merged

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Sep 17, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (checklist)

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? make lint (poetry install -E style).
  • Did you make sure to update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests? #63
  • Did you check that your code passes the unit tests pytest tests/ ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

#58.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Closing issues

Closes #58.

@Mr-Geekman Mr-Geekman added the bug Something isn't working label Sep 17, 2021
@Mr-Geekman Mr-Geekman self-assigned this Sep 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #62 (b6f3ea3) into master (ada6523) will decrease coverage by 4.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   90.49%   85.80%   -4.70%     
==========================================
  Files          45       45              
  Lines        2010     2015       +5     
==========================================
- Hits         1819     1729      -90     
- Misses        191      286      +95     
Impacted Files Coverage Δ
etna/models/prophet.py 98.70% <100.00%> (+0.10%) ⬆️
etna/transforms/pytorch_forecasting.py 26.38% <0.00%> (-73.62%) ⬇️
etna/models/nn/tft.py 38.88% <0.00%> (-61.12%) ⬇️
etna/models/nn/deepar.py 41.17% <0.00%> (-58.83%) ⬇️
etna/metrics/base.py 96.29% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada6523...b6f3ea3. Read the comment docs.

iKintosh
iKintosh previously approved these changes Sep 17, 2021
Copy link
Contributor

@iKintosh iKintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

for column_name in columns:
if column_name.startswith("regressor"):
regressors_columns.append(column_name)
elif column_name == "cap":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elif column_name in ["cap", "floor"]:
   regressors_columns.append(column_name)

@julia-shenshina
Copy link
Contributor

shouldn't it be regressor_cap and regressor_floor according to our columns naming rules?

iKintosh and others added 11 commits September 20, 2021 15:45
* Create CHANGELOG.md
* Add version 1.0.0
* add unreleased changes
* fix tsdataset getitem method

* fix style

* add test for all indexes

* fix imports

* add Nan info

* fix typo

Co-authored-by: an.alekseev <an.alekseev@tinkoff.ru>
* Add micro and macro mode for ScalerTransform

* Add macro/micro mode for power transformers


Co-authored-by: a.p.chikov <a.p.chikov@macbook-a.p.chikov>
@julia-shenshina julia-shenshina merged commit c4ed7d9 into master Sep 22, 2021
@iKintosh iKintosh deleted the issue-58 branch October 15, 2021 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cap/floor in ProphetModel
5 participants