Skip to content

Make in_column the first argument in every transform #215

Closed
3 tasks done
WinstonDovlatov opened this issue Oct 19, 2021 · 2 comments · Fixed by #247
Closed
3 tasks done

Make in_column the first argument in every transform #215

WinstonDovlatov opened this issue Oct 19, 2021 · 2 comments · Fixed by #247
Assignees
Labels
enhancement New feature or request

Comments

@WinstonDovlatov
Copy link
Contributor

🚀 Feature Request

There are transforms where in_column is the second argument. We want him to be the first.

Motivation

Unified simantics

Proposal

  1. Make in_column the first argument in every transform and set default values ​​for past first arguments for these transforms
  2. Make sure there are no others
  3. Check that the tests are working correctly

Test cases

No response

Alternatives

No response

Additional context

No response

Checklist

  • Added feature request
  • Added motivation
  • Added proposal
@WinstonDovlatov WinstonDovlatov added the enhancement New feature or request label Oct 19, 2021
@alex-hse-repository alex-hse-repository self-assigned this Oct 27, 2021
@julia-shenshina
Copy link
Contributor

lets discuss it first?

@julia-shenshina
Copy link
Contributor

in_column as a first arg, no default value for in_column

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants